🪟 🐛 Fix small memory leak by adding destructor to clear credit check interval #15891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
edmundito
approved these changes
Aug 23, 2022
|
Good catch! |
krishnaglick
approved these changes
Aug 23, 2022
| if (retryIntervalId.current) { | ||
| clearInterval(retryIntervalId.current); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Fun fact: You don't need to check if it's even set, clearInterval is happy with any input!
return () => clearInterval(retryIntervalId.current);
There was a problem hiding this comment.
Thanks for the tip!
This was referenced Aug 23, 2022
rodireich
pushed a commit
that referenced
this pull request
Aug 25, 2022
…interval (#15891) * fix memory leak by adding desctructor to clear credit check interval * simplify destructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a small memory leak we discovered in which the interval to check for credit increase after a credit purchase was not being cleared, causing the browser to continue to re-request the workspace every 3 seconds even if the user navigated away to another page.
How
Adds a destructor return method to the
useEffectOnce()call in RemainingCredits to clear the interval upon component unmount.Tested locally that this correctly fixes the leak - after this change, the repeated getWorkspace requests are not made after navigating to another page.
🚨 User Impact 🚨
No visible impact - just fewer unnecessary network calls