Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🐛 Fix small memory leak by adding destructor to clear credit check interval #15891

Merged
merged 3 commits into from
Aug 23, 2022
Merged

🪟 🐛 Fix small memory leak by adding destructor to clear credit check interval #15891

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0eb7fa
fix memory leak by adding desctructor to clear credit check interval
lmossman Aug 23, 2022
6a84efa
Merge branch 'master' into lmossman/fix-memory-leak
lmossman Aug 23, 2022
97bc13d
simplify destructor
lmossman Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions airbyte-webapp/src/packages/cloud/views/credits/CreditsPage/components/RemainingCredits.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ const RemainingCredits: React.FC<Props> = ({ selfServiceCheckoutEnabled }) => {
}, 3000);
}
}

return () => {
if (retryIntervalId.current) {
clearInterval(retryIntervalId.current);
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: You don't need to check if it's even set, clearInterval is happy with any input!
return () => clearInterval(retryIntervalId.current);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip!

});

useEffect(() => {
Expand Down