Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🔧 Upgrade array-type lint rule to error #16014

Closed
wants to merge 1 commit into from

Conversation

edmundito
Copy link
Contributor

What

Upgrades the @typescript-eslint/array-type rule from warn to error because this is one of the linting rules that will fail CI if it's not fixed for whatever reason (however, it is auto-fixable with a linter on auto save.)

Found in #15924

@edmundito edmundito added the area/frontend Related to the Airbyte webapp label Aug 26, 2022
@edmundito edmundito requested a review from a team as a code owner August 26, 2022 15:19
@github-actions github-actions bot removed the area/frontend Related to the Airbyte webapp label Aug 26, 2022
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edmundito
Copy link
Contributor Author

Auto linting in #16134 should ideally fix this issue, same as auto save in vscode, so closing.

@edmundito edmundito closed this Sep 8, 2022
@edmundito edmundito deleted the edmundito/lint-array-types-error branch September 8, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants