Add stylelint to pre-commit tasks and update vscode settings to format and lint scss #16134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update lint-staged to lint files
edmundito
commented
Aug 30, 2022
| "esbenp.prettier-vscode", | ||
| "ms-vsliveshare.vsliveshare", |
There was a problem hiding this comment.
This extension seemed extraneous what was needed, so I removed it.
edmundito
commented
Aug 30, 2022
| @@ -137,8 +137,14 @@ | |||
| } | |||
| }, | |||
| "lint-staged": { | |||
| "src/**/*.{js,jsx,ts,tsx,json,css,scss,md}": [ | |||
| "src/**/*.{js,jsx,ts,tsx,json}": [ | |||
| "eslint --fix" | |||
There was a problem hiding this comment.
Eslint already runs prettier
krishnaglick
approved these changes
Sep 7, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
Update lint-staged to lint files
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
Update lint-staged to lint files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add stylelint to pre-commit tasks and update vscode settings to format and lint scss.
How
Updates package.json and vscode settings files.