Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT Destination: Password is not marked as a secret field in spec #16263

Merged
merged 15 commits into from
Sep 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
30b6eac
[16219] MQTT Destination: Password is not marked as a secret field in…
alexandr-shegeda Sep 1, 2022
044dbce
Merge branch 'master' into osheg/16219-destination-mqtt
alexandr-shegeda Sep 2, 2022
ec299af
[16219] MQTT Destination: Password is not marked as a secret field in…
alexandr-shegeda Sep 2, 2022
3d34b1e
Merge remote-tracking branch 'origin/osheg/16219-destination-mqtt' in…
alexandr-shegeda Sep 2, 2022
9c7f5ac
Merge branch 'master' into osheg/16219-destination-mqtt
alexandr-shegeda Sep 5, 2022
aa1c9d6
[16219] MQTT Destination: Password is not marked as a secret field in…
alexandr-shegeda Sep 6, 2022
e26d9ee
Merge branch 'master' into osheg/16219-destination-mqtt
alexandr-shegeda Sep 6, 2022
022a9f8
[16219] MQTT Destination: Password is not marked as a secret field in…
alexandr-shegeda Sep 6, 2022
6a563c7
Merge remote-tracking branch 'origin/osheg/16219-destination-mqtt' in…
alexandr-shegeda Sep 6, 2022
32e2b19
[16219] MQTT Destination: Password is not marked as a secret field in…
alexandr-shegeda Sep 6, 2022
541d0a9
[16219] MQTT Destination: Password is not marked as a secret field in…
alexandr-shegeda Sep 7, 2022
ce98388
[16219] MQTT Destination: Password is not marked as a secret field in…
alexandr-shegeda Sep 7, 2022
9b73d28
Merge branch 'master' into osheg/16219-destination-mqtt
alexandr-shegeda Sep 7, 2022
c6c6155
auto-bump connector version [ci skip]
octavia-squidington-iii Sep 7, 2022
23fd599
Merge branch 'osheg/16219-destination-mqtt' of https://github.com/air…
octavia-squidington-iii Sep 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
- name: MQTT
destinationDefinitionId: f3802bc4-5406-4752-9e8d-01e504ca8194
dockerRepository: airbyte/destination-mqtt
dockerImageTag: 0.1.2
dockerImageTag: 0.1.3
documentationUrl: https://docs.airbyte.io/integrations/destinations/mqtt
icon: mqtt.svg
releaseStage: alpha
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2406,7 +2406,7 @@
supported_destination_sync_modes:
- "overwrite"
- "append"
- dockerImage: "airbyte/destination-mqtt:0.1.2"
- dockerImage: "airbyte/destination-mqtt:0.1.3"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/destinations/mqtt"
connectionSpecification:
Expand Down Expand Up @@ -2447,6 +2447,7 @@
title: "Password"
description: "Password to use for the connection."
type: "string"
airbyte_secret: true
topic_pattern:
title: "Topic pattern"
description: "Topic pattern in which the records will be sent. You can use\
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-mqtt

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.1.2
LABEL io.airbyte.version=0.1.3
LABEL io.airbyte.name=airbyte/destination-mqtt
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ private MqttConnectOptions buildMqttConnectOptions(final JsonNode config) {
options.setPassword(config.get("password").asText().toCharArray());
}

if (config.has("max_in_flight") && !config.get("max_in_flight").asText().isBlank()) {
options.setMaxInflight(config.get("max_in_flight").asInt());
}

return options;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
"password": {
"title": "Password",
"description": "Password to use for the connection.",
"type": "string"
"type": "string",
"airbyte_secret": true
},
"topic_pattern": {
"title": "Topic pattern",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ protected JsonNode getConfig() throws UnknownHostException {
.put("clean_session", true)
.put("message_retained", false)
.put("message_qos", "EXACTLY_ONCE")
.put("max_in_flight", 1000)
.build());
}

Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/mqtt.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,6 @@ _NOTE_: MQTT version 5 is not supported yet.

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.1.3 | 2022-09-02 | [16263](https://github.com/airbytehq/airbyte/pull/16263) | Marked password field in spec as airbyte_secret |
| 0.1.2 | 2022-07-12 | [14648](https://github.com/airbytehq/airbyte/pull/14648) | Include lifecycle management |
| 0.1.1 | 2022-05-24 | [13099](https://github.com/airbytehq/airbyte/pull/13099) | Fixed build's tests |