MQTT Destination: Password is not marked as a secret field in spec #16263

alexandr-shegeda · 2022-09-02T07:18:21Z

What

The password field of the MQTT destination is not marked as a secret field in the connector specification and thus this field will not show correctly as a password field in the CI, which leads to several potential security drawbacks.

How

Marked the password field in spec as secret

🚨 User Impact 🚨

No user impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

… spec

github-actions · 2022-09-02T07:19:11Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

alexandr-shegeda · 2022-09-02T08:30:39Z

/test connector=connectors/destination-mqtt

alexandr-shegeda · 2022-09-02T11:17:17Z

/test connector=connectors/destination-mqtt

🕑 connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2978651876
❌ connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2978651876
🐛 https://gradle.com/s/a4vg6s2wkcwtc

Build Failed

Test summary info:

Could not find result summary

… spec

github-actions · 2022-09-02T11:19:02Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

…to osheg/16219-destination-mqtt

github-actions · 2022-09-02T11:20:17Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

alexandr-shegeda · 2022-09-05T11:33:18Z

/test connector=connectors/destination-mqtt

🕑 connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2992868680
❌ connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2992868680
🐛 https://gradle.com/s/ppyxvtrwocmqg

Build Failed

Test summary info:

Could not find result summary

alexandr-shegeda · 2022-09-05T17:37:47Z

/test connector=connectors/destination-mqtt

🕑 connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2995148966
❌ connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2995148966
🐛 https://gradle.com/s/atq3stbi5tt6g

Build Failed

Test summary info:

Could not find result summary

github-actions · 2022-09-05T17:38:06Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

… spec added logs for troubleshooting

alexandr-shegeda · 2022-09-06T11:14:06Z

/test connector=connectors/destination-mqtt

🕑 connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2999695196
❌ connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2999695196
🐛 https://gradle.com/s/6wvjqnzjiavz4

Build Failed

Test summary info:

Could not find result summary

github-actions · 2022-09-06T11:14:29Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

… spec updated maxinflight and connect_timeout for test only

…to osheg/16219-destination-mqtt

github-actions · 2022-09-06T11:43:14Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

alexandr-shegeda · 2022-09-06T11:43:41Z

/test connector=connectors/destination-mqtt

alexandr-shegeda · 2022-09-06T12:06:08Z

/test connector=connectors/destination-mqtt

🕑 connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2999995344
❌ connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2999995344
🐛 https://gradle.com/s/7ag4up7dvhwuk

Build Failed

Test summary info:

Could not find result summary

… spec updated maxinflight for test only

github-actions · 2022-09-06T12:39:09Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

alexandr-shegeda · 2022-09-06T12:40:38Z

/test connector=connectors/destination-mqtt

🕑 connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/3000216762
❌ connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/3000216762
🐛 https://gradle.com/s/l7ngiar4iefiw

Build Failed

Test summary info:

Could not find result summary

alexandr-shegeda · 2022-09-07T04:25:26Z

/test connector=connectors/destination-mqtt

🕑 connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/3005036580
❌ connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/3005036580
🐛 https://gradle.com/s/6ubsrcqpvpgpy

Build Failed

Test summary info:

Could not find result summary

… spec added config param max_in_flight for test

alexandr-shegeda · 2022-09-07T09:12:16Z

/test connector=connectors/destination-mqtt

🕑 connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/3006423705
✅ connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/3006423705
No Python unittests run

Build Passed

Test summary info:

All Passed

github-actions · 2022-09-07T09:12:44Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

… spec made refactoring

alexandr-shegeda · 2022-09-07T10:09:18Z

/publish connector=connectors/destination-mqtt

🕑 Publishing the following connectors:
connectors/destination-mqtt
https://github.com/airbytehq/airbyte/actions/runs/3006788792

Connector	Did it publish?	Were definitions generated?
connectors/destination-mqtt	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2022-09-07T10:09:35Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

github-actions · 2022-09-07T10:25:32Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

…bytehq/airbyte into osheg/16219-destination-mqtt

github-actions · 2022-09-07T10:36:44Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-mqtt

…irbytehq#16263) * [16219] MQTT Destination: Password is not marked as a secret field in spec * [16219] MQTT Destination: Password is not marked as a secret field in spec * [16219] MQTT Destination: Password is not marked as a secret field in spec added logs for troubleshooting * [16219] MQTT Destination: Password is not marked as a secret field in spec updated maxinflight and connect_timeout for test only * [16219] MQTT Destination: Password is not marked as a secret field in spec updated maxinflight for test only * [16219] MQTT Destination: Password is not marked as a secret field in spec added config param max_in_flight for test * [16219] MQTT Destination: Password is not marked as a secret field in spec made refactoring * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

[16219] MQTT Destination: Password is not marked as a secret field in…

30b6eac

… spec

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 2, 2022

octavia-squidington-iii added the connectors/destination/mqtt label Sep 2, 2022

alexandr-shegeda assigned DoNotPanicUA and kimerinn Sep 2, 2022

alexandr-shegeda and others added 2 commits September 2, 2022 14:18

Merge branch 'master' into osheg/16219-destination-mqtt

044dbce

[16219] MQTT Destination: Password is not marked as a secret field in…

ec299af

… spec

Merge remote-tracking branch 'origin/osheg/16219-destination-mqtt' in…

3d34b1e

…to osheg/16219-destination-mqtt

DoNotPanicUA removed their assignment Sep 5, 2022

Merge branch 'master' into osheg/16219-destination-mqtt

9c7f5ac

alexandr-shegeda and others added 2 commits September 6, 2022 14:05

[16219] MQTT Destination: Password is not marked as a secret field in…

aa1c9d6

… spec added logs for troubleshooting

Merge branch 'master' into osheg/16219-destination-mqtt

e26d9ee

alexandr-shegeda added 2 commits September 6, 2022 14:42

[16219] MQTT Destination: Password is not marked as a secret field in…

022a9f8

… spec updated maxinflight and connect_timeout for test only

Merge remote-tracking branch 'origin/osheg/16219-destination-mqtt' in…

6a563c7

…to osheg/16219-destination-mqtt

[16219] MQTT Destination: Password is not marked as a secret field in…

32e2b19

… spec updated maxinflight for test only

[16219] MQTT Destination: Password is not marked as a secret field in…

541d0a9

… spec added config param max_in_flight for test

andriikorotkov approved these changes Sep 7, 2022

View reviewed changes

yurii-bidiuk approved these changes Sep 7, 2022

View reviewed changes

[16219] MQTT Destination: Password is not marked as a secret field in…

ce98388

… spec made refactoring

Merge branch 'master' into osheg/16219-destination-mqtt

9b73d28

octavia-squidington-iii added 2 commits September 7, 2022 10:35

auto-bump connector version [ci skip]

c6c6155

Merge branch 'osheg/16219-destination-mqtt' of https://github.com/air…

23fd599

…bytehq/airbyte into osheg/16219-destination-mqtt

alexandr-shegeda merged commit d105177 into master Sep 7, 2022

alexandr-shegeda deleted the osheg/16219-destination-mqtt branch September 7, 2022 10:36

alexandr-shegeda linked an issue Sep 7, 2022 that may be closed by this pull request

MQTT Destination: Password is not marked as a secret field in spec #16219

Closed

octavia-squidington-iii temporarily deployed to more-secrets September 7, 2022 10:38 Inactive

octavia-squidington-iii mentioned this pull request Sep 12, 2022

Bump Airbyte version from 0.40.4 to 0.40.5 #16610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MQTT Destination: Password is not marked as a secret field in spec #16263

MQTT Destination: Password is not marked as a secret field in spec #16263

alexandr-shegeda commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

alexandr-shegeda commented Sep 2, 2022

alexandr-shegeda commented Sep 2, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

alexandr-shegeda commented Sep 5, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 5, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 5, 2022

alexandr-shegeda commented Sep 6, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

alexandr-shegeda commented Sep 6, 2022

alexandr-shegeda commented Sep 6, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 6, 2022

alexandr-shegeda commented Sep 6, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 7, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 7, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 7, 2022

alexandr-shegeda commented Sep 7, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 7, 2022

github-actions bot commented Sep 7, 2022

github-actions bot commented Sep 7, 2022

MQTT Destination: Password is not marked as a secret field in spec #16263

MQTT Destination: Password is not marked as a secret field in spec #16263

Conversation

alexandr-shegeda commented Sep 2, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

github-actions bot commented Sep 2, 2022

alexandr-shegeda commented Sep 2, 2022

alexandr-shegeda commented Sep 2, 2022 • edited by github-actions bot Loading

Build Failed

github-actions bot commented Sep 2, 2022

github-actions bot commented Sep 2, 2022

alexandr-shegeda commented Sep 5, 2022 • edited by github-actions bot Loading

Build Failed

alexandr-shegeda commented Sep 5, 2022 • edited by github-actions bot Loading

Build Failed

github-actions bot commented Sep 5, 2022

alexandr-shegeda commented Sep 6, 2022 • edited by github-actions bot Loading

Build Failed

github-actions bot commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

alexandr-shegeda commented Sep 6, 2022

alexandr-shegeda commented Sep 6, 2022 • edited by github-actions bot Loading

Build Failed

github-actions bot commented Sep 6, 2022

alexandr-shegeda commented Sep 6, 2022 • edited by github-actions bot Loading

Build Failed

alexandr-shegeda commented Sep 7, 2022 • edited by github-actions bot Loading

Build Failed

alexandr-shegeda commented Sep 7, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Sep 7, 2022

alexandr-shegeda commented Sep 7, 2022 • edited by github-actions bot Loading

github-actions bot commented Sep 7, 2022

github-actions bot commented Sep 7, 2022

github-actions bot commented Sep 7, 2022

alexandr-shegeda commented Sep 2, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 5, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 5, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 6, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 6, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 6, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 7, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 7, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Sep 7, 2022 •

edited by github-actions bot

Loading