MQTT Destination: Password is not marked as a secret field in spec (a…

…irbytehq#16263) * [16219] MQTT Destination: Password is not marked as a secret field in spec * [16219] MQTT Destination: Password is not marked as a secret field in spec * [16219] MQTT Destination: Password is not marked as a secret field in spec added logs for troubleshooting * [16219] MQTT Destination: Password is not marked as a secret field in spec updated maxinflight and connect_timeout for test only * [16219] MQTT Destination: Password is not marked as a secret field in spec updated maxinflight for test only * [16219] MQTT Destination: Password is not marked as a secret field in spec added config param max_in_flight for test * [16219] MQTT Destination: Password is not marked as a secret field in spec made refactoring * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt · Oct 31, 2022 · 7d36e9f · 7d36e9f
1 parent 22d15ad
commit 7d36e9f
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 4 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml b/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
@@ -161,7 +161,7 @@
 - name: MQTT
   destinationDefinitionId: f3802bc4-5406-4752-9e8d-01e504ca8194
   dockerRepository: airbyte/destination-mqtt
-  dockerImageTag: 0.1.2
+  dockerImageTag: 0.1.3
   documentationUrl: https://docs.airbyte.io/integrations/destinations/mqtt
   icon: mqtt.svg
   releaseStage: alpha

diff --git a/airbyte-config/init/src/main/resources/seed/destination_specs.yaml b/airbyte-config/init/src/main/resources/seed/destination_specs.yaml
@@ -2406,7 +2406,7 @@
     supported_destination_sync_modes:
     - "overwrite"
     - "append"
-- dockerImage: "airbyte/destination-mqtt:0.1.2"
+- dockerImage: "airbyte/destination-mqtt:0.1.3"
   spec:
     documentationUrl: "https://docs.airbyte.io/integrations/destinations/mqtt"
     connectionSpecification:
@@ -2447,6 +2447,7 @@
           title: "Password"
           description: "Password to use for the connection."
           type: "string"
+          airbyte_secret: true
         topic_pattern:
           title: "Topic pattern"
           description: "Topic pattern in which the records will be sent. You can use\

diff --git a/airbyte-integrations/connectors/destination-mqtt/Dockerfile b/airbyte-integrations/connectors/destination-mqtt/Dockerfile
@@ -16,5 +16,5 @@ ENV APPLICATION destination-mqtt
 
 COPY --from=build /airbyte /airbyte
 
-LABEL io.airbyte.version=0.1.2
+LABEL io.airbyte.version=0.1.3
 LABEL io.airbyte.name=airbyte/destination-mqtt
diff --git a/...on-mqtt/src/main/java/io/airbyte/integrations/destination/mqtt/MqttDestinationConfig.java b/...on-mqtt/src/main/java/io/airbyte/integrations/destination/mqtt/MqttDestinationConfig.java
@@ -85,6 +85,10 @@ private MqttConnectOptions buildMqttConnectOptions(final JsonNode config) {
       options.setPassword(config.get("password").asText().toCharArray());
     }
 
+    if (config.has("max_in_flight") && !config.get("max_in_flight").asText().isBlank()) {
+      options.setMaxInflight(config.get("max_in_flight").asInt());
+    }
+
     return options;
   }
 

diff --git a/airbyte-integrations/connectors/destination-mqtt/src/main/resources/spec.json b/airbyte-integrations/connectors/destination-mqtt/src/main/resources/spec.json
@@ -46,7 +46,8 @@
       "password": {
         "title": "Password",
         "description": "Password to use for the connection.",
-        "type": "string"
+        "type": "string",
+        "airbyte_secret": true
       },
       "topic_pattern": {
         "title": "Topic pattern",

diff --git a/...egration/java/io/airbyte/integrations/destination/mqtt/MqttDestinationAcceptanceTest.java b/...egration/java/io/airbyte/integrations/destination/mqtt/MqttDestinationAcceptanceTest.java
@@ -63,6 +63,7 @@ protected JsonNode getConfig() throws UnknownHostException {
         .put("clean_session", true)
         .put("message_retained", false)
         .put("message_qos", "EXACTLY_ONCE")
+        .put("max_in_flight", 1000)
         .build());
   }
 

diff --git a/docs/integrations/destinations/mqtt.md b/docs/integrations/destinations/mqtt.md
@@ -85,5 +85,6 @@ _NOTE_: MQTT version 5 is not supported yet.
 
 | Version | Date | Pull Request | Subject |
 | :--- | :--- | :--- | :--- |
+| 0.1.3 | 2022-09-02 | [16263](https://github.com/airbytehq/airbyte/pull/16263) | Marked password field in spec as airbyte_secret |
 | 0.1.2 | 2022-07-12 | [14648](https://github.com/airbytehq/airbyte/pull/14648) | Include lifecycle management |
 | 0.1.1 | 2022-05-24 | [13099](https://github.com/airbytehq/airbyte/pull/13099) | Fixed build's tests |