Source Hubspot: remove FeedbackSubmissions stream #16632

davydov-d · 2022-09-13T10:12:08Z

What

https://github.com/airbytehq/oncall/issues/586
Removing the stream as the one using unstable (beta) API and causing 500 http errors we can not fix

davydov-d · 2022-09-13T10:13:01Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3044213298
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3044213298
🐛 https://gradle.com/s/o6cg54oziimtu

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_source.py::test_streams - assert 26 == 27
	 �[31m================== �[31m�[1m1 failed�[0m, �[32m93 passed�[0m, �[33m414 warnings�[0m�[31m in 5.64s�[0m�[31m ==================�[0m

davydov-d · 2022-09-13T10:22:44Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3044271870
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3044271870
🐛 https://gradle.com/s/qbyhfggptaeew

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - so...
=================== 1 failed, 34 passed in 244.37s (0:04:04) ===================

davydov-d · 2022-09-13T11:25:03Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3044650525
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3044650525
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/source.py         90     19    79%
source_hubspot/streams.py       826    200    76%
-------------------------------------------------
TOTAL                           997    226    77%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       826     78    91%
source_hubspot/source.py         90     18    80%
-------------------------------------------------
TOTAL                           997     99    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1325    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:235: Backward compatibility tests are disabled for version 0.1.83.
================== 34 passed, 1 skipped in 240.88s (0:04:00) ===================

airbyte-integrations/connectors/source-hubspot/Dockerfile

alafanechere · 2022-09-13T12:55:19Z

airbyte-integrations/connectors/source-hubspot/acceptance-test-config.yml

  basic_read:
    - config_path: "secrets/config.json"
      timeout_seconds: 600
      configured_catalog_path: "sample_files/basic_read_catalog.json"
-      empty_streams: ["form_submissions", "ticket_pipelines", "engagements_meetings", "engagements_emails", "engagements", "feedback_submissions", "engagements_calls", "quotes"]
+      empty_streams: ["form_submissions", "ticket_pipelines", "engagements_meetings", "engagements_emails", "engagements", "engagements_calls", "quotes"]


@YowanR, these streams are empty on our sandbox account it means they are not properly covered by SAT and might not work as expected in production. Do you think you could create and prioritize the provisioning of our test account with some data on this stream so we can keep the wolf from the door 😄

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py

davydov-d · 2022-09-13T13:09:09Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3045326176
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3045326176
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/source.py         90     19    79%
source_hubspot/streams.py       831    200    76%
-------------------------------------------------
TOTAL                          1002    226    77%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       831     78    91%
source_hubspot/source.py         90     18    80%
-------------------------------------------------
TOTAL                          1002     99    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1325    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:235: Backward compatibility tests are disabled for version 0.1.83.
================== 34 passed, 1 skipped in 272.58s (0:04:32) ===================

alafanechere

Thank you for the changes. Feel free to merge if the tests are passing.

davydov-d · 2022-09-13T14:38:23Z

/publish connector=connectors/source-hubspot

🕑 Publishing the following connectors:
connectors/source-hubspot
https://github.com/airbytehq/airbyte/actions/runs/3045988612

Connector	Did it publish?	Were definitions generated?
connectors/source-hubspot	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* airbytehq#586 source hubspot: rm FeedbackSubmissions stream * airbytehq#586 source hubspot: upd changelog * airbytehq#586 source hubspot: fix unit tests * airbytehq#586 source hubspot: fix SATs * airbytehq#586 source hubspot: review fixes * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

#586 source hubspot: rm FeedbackSubmissions stream

43204e4

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 13, 2022

octavia-squidington-iii added the connectors/source/hubspot label Sep 13, 2022

#586 source hubspot: upd changelog

0bcae89

davydov-d requested review from alafanechere, arsenlosenko, grubberr and lazebnyi September 13, 2022 10:13

#586 source hubspot: fix unit tests

4ebf444

lazebnyi approved these changes Sep 13, 2022

View reviewed changes

arsenlosenko approved these changes Sep 13, 2022

View reviewed changes

#586 source hubspot: fix SATs

4bc9ff0

alafanechere requested changes Sep 13, 2022

View reviewed changes

#586 source hubspot: review fixes

3f04751

davydov-d requested a review from alafanechere September 13, 2022 13:10

alafanechere approved these changes Sep 13, 2022

View reviewed changes

auto-bump connector version [ci skip]

84f735f

davydov-d merged commit 7934eed into master Sep 13, 2022

davydov-d deleted the ddavydov/#586-source-hubspot-disable-feedback-submissions-stream branch September 13, 2022 15:08

octavia-squidington-iii mentioned this pull request Sep 13, 2022

Bump Airbyte version from 0.40.5 to 0.40.6 #16656

Merged

marcosmarxm mentioned this pull request Jan 18, 2024

✨ Source Hubspot: add new stream Feedback Submissions #34048

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Hubspot: remove FeedbackSubmissions stream #16632

Source Hubspot: remove FeedbackSubmissions stream #16632

davydov-d commented Sep 13, 2022 •

edited

Loading

davydov-d commented Sep 13, 2022 •

edited by github-actions bot

Loading

davydov-d commented Sep 13, 2022 •

edited by github-actions bot

Loading

davydov-d commented Sep 13, 2022 •

edited by github-actions bot

Loading

alafanechere Sep 13, 2022 •

edited

Loading

davydov-d commented Sep 13, 2022 •

edited by github-actions bot

Loading

alafanechere left a comment

davydov-d commented Sep 13, 2022 •

edited by github-actions bot

Loading

Source Hubspot: remove FeedbackSubmissions stream #16632

Source Hubspot: remove FeedbackSubmissions stream #16632

Conversation

davydov-d commented Sep 13, 2022 • edited Loading

What

davydov-d commented Sep 13, 2022 • edited by github-actions bot Loading

Build Failed

davydov-d commented Sep 13, 2022 • edited by github-actions bot Loading

Build Failed

davydov-d commented Sep 13, 2022 • edited by github-actions bot Loading

Build Passed

alafanechere Sep 13, 2022 • edited Loading

Choose a reason for hiding this comment

davydov-d commented Sep 13, 2022 • edited by github-actions bot Loading

Build Passed

alafanechere left a comment

Choose a reason for hiding this comment

davydov-d commented Sep 13, 2022 • edited by github-actions bot Loading

davydov-d commented Sep 13, 2022 •

edited

Loading

davydov-d commented Sep 13, 2022 •

edited by github-actions bot

Loading

davydov-d commented Sep 13, 2022 •

edited by github-actions bot

Loading

davydov-d commented Sep 13, 2022 •

edited by github-actions bot

Loading

alafanechere Sep 13, 2022 •

edited

Loading

davydov-d commented Sep 13, 2022 •

edited by github-actions bot

Loading

davydov-d commented Sep 13, 2022 •

edited by github-actions bot

Loading