-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Hubspot: add new stream Feedback Submissions #34048
✨ Source Hubspot: add new stream Feedback Submissions #34048
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
…dback-submissions
…dback-submissions
Thanks @mariana-s-fernandes! The previous contribution (#16632) removed the Feedback Submissions stream from the certified connector due to issues with a beta endpoint. Check HubSpot documentation (https://developers.hubspot.com/docs/api/crm/feedback-submissions) for details. Feel free to use it for your company project by building the connector locally with your changes. Once the endpoint becomes GA in HubSpot, we can reevaluate enabling it in the Airbyte source. |
What
Adds Feedback Submissions stream from Hubspot
How
The stream was already defined, just had to pass its reference in different files
Recommended reading order
airbyte-integrations/connectors/source-hubspot/README.md
docs/integrations/sources/hubspot.md
airbyte-integrations/connectors/source-hubspot/source_hubspot/source.py
airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py
🚨 User Impact 🚨
There are no breaking changes.
The user should be able to see a new stream for Feedback Submissions, so there was a bump in the minor version, as per https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook#semantic-versioning-for-connectors
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.0.1
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds
then checking in your changesUpdating the Python CDK
Airbyter
Before merging:
--use-local-cdk --name=source-<connector>
as optionsairbyte-ci connectors --use-local-cdk --name=source-<connector> test
After merging: