🪟 🐛 Focus Connection Name input on field selection #20162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
teallarson
changed the title
This was referenced Jan 6, 2023
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
closes #19229
BEFORE:
We would render the input, but not focus it.
https://www.loom.com/share/815b76c0ef8c48e2a0887a62b087d881
AFTER:
I added
autoFocusto the Input element.The problem was that the field was never actually focused, just rendered, so the
blurnever got triggered.This is technically against our a11y linting rules however I am breaking this rule intentionally.
autoFocusis not recommended because it can lead to unexpected behavior for users. However, when clicking into an input (or triggering the input appearing by clicking that button), it does not seem unexpected that the input would be focused.This resolves the original issue as seen here:
https://www.loom.com/share/029c011240dd40ee815a5ede1f1723e6