Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🐛 Focus Connection Name input on field selection #20162

Merged
merged 19 commits into from
Jan 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
selectPrimaryKeyField,
checkPreFilledPrimaryKeyField,
checkStreamFields,
expandStreamDetails
expandStreamDetails,
} from "pages/replicationPage";
import { openSourceDestinationFromGrid, goToSourcePage } from "pages/sourcePage";
import { goToSettingsPage } from "pages/settingsConnectionPage";
Expand Down Expand Up @@ -155,11 +155,6 @@ describe("Connection - main actions", () => {

createTestConnection(sourceName, destName);

cy.get("div").contains(sourceName).should("exist");
cy.get("div").contains(destName).should("exist");

openSourceDestinationFromGrid(sourceName);

goToReplicationTab();

selectSchedule("Cron");
Expand Down Expand Up @@ -558,7 +553,6 @@ describe("Connection - detect changes in source", () => {
cy.get("div").contains(destName).should("exist");

makeChangesInDBSource();
openSourceDestinationFromGrid(sourceName);
goToReplicationTab();
refreshSourceSchemaBtnClick();

Expand Down
18 changes: 8 additions & 10 deletions airbyte-webapp-e2e-tests/cypress/pages/replicationPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,14 @@ export const selectCursorField = (value: string) => {
cy.get(`.react-select__option`).contains(value).click();
};

export const checkStreamFields = (listNames: Array<String>, listTypes: Array<String>,) => {
cy.get(streamFieldNames)
.each(($span, i) => {
expect($span.text()).to.equal(listNames[i]);
});

cy.get(streamDataTypes)
.each(($span, i) => {
expect($span.text()).to.equal(listTypes[i]);
});
export const checkStreamFields = (listNames: string[], listTypes: string[]) => {
cy.get(streamFieldNames).each(($span, i) => {
expect($span.text()).to.equal(listNames[i]);
});

cy.get(streamDataTypes).each(($span, i) => {
expect($span.text()).to.equal(listTypes[i]);
});
};

export const checkCursorField = (expectedValue: string) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable jsx-a11y/no-autofocus */
import { faPenToSquare } from "@fortawesome/free-regular-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import React, { ChangeEvent, useState } from "react";
Expand Down Expand Up @@ -77,6 +78,7 @@ export const ConnectionName: React.FC = () => {
onEscape={onEscape}
onEnter={onEnter}
disabled={loading}
autoFocus
/>
</div>
</div>
Expand Down