-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Fauna: fix bug during discover step #20275
Conversation
/test connector=connectors/source-fauna
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @macmv do you mind bump the connector version, docs and seed file?
Yeah, sure thing. I just bumped the version in:
LMK if you need any other changes. |
/publish connector=connectors/source-fauna
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Hello 👋:skin-tone-2: and thank you for your contribution! Airbyte has instituted a code freeze between 19 and 30 December, to make sure there are no disruptions during the holidays. If you have any questions or need further clarification, please don't hesitate to ping via Slack. |
@marcosmarxm could we get another look at this now that the code freeze is over? |
This comment was marked as duplicate.
This comment was marked as duplicate.
@macmv could you run We have a 24 hour code freeze in place but after that we should be good to merge. |
…ndex with no terms
Thanks for the reply @natalyjazzviolin. I just ran it, and it completed successfully and bumped the connector version in the seed file. I also rebased to the latest version of |
Hey @natalyjazzviolin I've updated the PR, could you take another look at it? |
@misteryeo can you help us get this out? |
Closing this PR in favor of the non-forked one where we can see that the build passes: |
Sweet, thanks! |
What
In the fauna source,
discover
would crash if there were any indexes with no terms or no values. This PR fixes that bug.How
Bug is fixed, and added a test to validate it.
🚨 User Impact 🚨
None.
Tests
Unit
Integration