🐛 Source Fauna: fix bug during discover step

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

@@ -539,7 +539,7 @@
 - name: Fauna
   sourceDefinitionId: 3825db3e-c94b-42ac-bd53-b5a9507ace2b
   dockerRepository: airbyte/source-fauna
-  dockerImageTag: 0.1.0
+  dockerImageTag: 0.1.1
   documentationUrl: https://docs.airbyte.com/integrations/sources/fauna
   icon: fauna.svg
   sourceType: database

airbyte-config/init/src/main/resources/seed/source_specs.yaml

@@ -4112,7 +4112,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-fauna:0.1.0"
+- dockerImage: "airbyte/source-fauna:0.1.1"
   spec:
     documentationUrl: "https://github.com/fauna/airbyte/blob/source-fauna/docs/integrations/sources/fauna.md"
     connectionSpecification:

airbyte-integrations/connectors/source-fauna/Dockerfile

@@ -34,5 +34,5 @@ COPY source_fauna ./source_fauna
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.0
+LABEL io.airbyte.version=0.1.1
 LABEL io.airbyte.name=airbyte/source-fauna

airbyte-integrations/connectors/source-fauna/source_fauna/source.py

@@ -240,8 +240,8 @@ def discover(self, logger: AirbyteLogger, config: json) -> AirbyteCatalog:
                         type(source) is Ref
                         and source.collection() == Ref("collections")
                         # Index must have 2 values and no terms
-                        and len(index["values"]) == 2
-                        and len(index["terms"]) == 0
+                        and ("values" in index and len(index["values"]) == 2)
+                        and (("terms" in index and len(index["terms"]) == 0) or "terms" not in index)
                         # Index values must be ts and ref
                         and index["values"][0] == {"field": "ts"}
                         and index["values"][1] == {"field": "ref"}

airbyte-integrations/connectors/source-fauna/unit_tests/database_test.py

@@ -89,6 +89,16 @@ def setup_database(source: SourceFauna):
             }
         ),
     )
+    # This index just *existing* used to crash the connector, because it has no
+    # terms or values.
+    source.client.query(
+        q.create_index(
+            {
+                "name": "breaks_things",
+                "source": q.collection("foo"),
+            }
+        ),
+    )
     print("Database is setup!")
 
     # Store all the refs and ts of the documents we created, so that we can validate them
@@ -160,6 +170,28 @@ def setup_container():
         raise
 
 
+def run_discover_test(source: SourceFauna, logger):
+    # See `test_util.py` for these values
+    catalog = source.discover(logger, {
+        "secret": "secret",
+        "domain": "localhost",
+        "port": 9000,
+        "scheme": "http",
+        "collection": {
+            "page_size": 64,
+            "deletions": {
+                "deletion_mode": "ignore",
+            }
+        }
+    })
+    assert len(catalog.streams) == 1
+    stream = catalog.streams[0]
+    assert stream.name == "foo"
+    assert stream.supported_sync_modes == [SyncMode.full_refresh, SyncMode.incremental]
+    assert stream.source_defined_cursor is True
+    assert stream.default_cursor_field == ["ts"]
+
+
 def run_add_removes_test(source: SourceFauna, logger, stream: ConfiguredAirbyteStream):
     source._setup_client(FullConfig.localhost())
     source.client.query(q.create(ref(105, "foo"), {"data": {"a": 10}}))
@@ -477,6 +509,7 @@ def run_updates_test(db_data, source: SourceFauna, logger, catalog: ConfiguredAi
 
 def run_test(db_data, source: SourceFauna):
     logger = mock_logger()
+    run_discover_test(source, logger)
     stream = ConfiguredAirbyteStream(
         stream=AirbyteStream(name="foo", json_schema={}, supported_sync_modes=[SyncMode.incremental, SyncMode.full_refresh]),
         sync_mode=SyncMode.incremental,
@@ -489,7 +522,7 @@ def run_test(db_data, source: SourceFauna):
     run_general_remove_test(source, logger)
 
 
-def test_incremental_reads():
+def test_database():
     container, db_data, source = setup_container()
 
     try:

docs/integrations/sources/fauna.md

@@ -222,6 +222,7 @@ FQL [`Select`](https://docs.fauna.com/fauna/current/api/fql/functions/select) is
 
 ## Changelog
 
-| Version | Date       | Pull Request                                             | Subject          |
-| ------- | ---------- | -------------------------------------------------------- | ---------------- |
-| 0.1.0   | 2022-11-17 | [15274](https://github.com/airbytehq/airbyte/pull/15274) | Add Fauna Source |
+| Version | Date       | Pull Request                                             | Subject                         |
+| ------- | ---------- | -------------------------------------------------------- | ------------------------------- |
+| 0.1.1   | 2022-12-12 | [20275](https://github.com/airbytehq/airbyte/pull/20275) | Fix index lookup with no values |
+| 0.1.0   | 2022-11-17 | [15274](https://github.com/airbytehq/airbyte/pull/15274) | Add Fauna Source                |