Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Python CDK: fix StopIteration error for check_availability #20429

Merged
merged 4 commits into from
Dec 13, 2022
Merged

🐛 Python CDK: fix StopIteration error for check_availability #20429

merged 4 commits into from
Dec 13, 2022

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Dec 13, 2022 •
edited
Loading

What

Fixed missing handling of StopIteration after: #19977

How

  • added try/except statement to handle StopIteration error for empty streams

@bazarnov bazarnov requested a review from a team as a code owner December 13, 2022 12:35
@bazarnov bazarnov self-assigned this Dec 13, 2022
@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 13, 2022 •
edited by github-actions bot
Loading

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/3685443589
✅ https://github.com/airbytehq/airbyte/actions/runs/3685443589

@octavia-squidington-iv octavia-squidington-iv added the CDK Connector Development Kit label Dec 13, 2022
erohmensing
erohmensing approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test and confirmed that the test fails on master but passes with your fix. LGTM, thank you for catching!

@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 13, 2022 •
edited by github-actions bot
Loading

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/3686918469
✅ https://github.com/airbytehq/airbyte/actions/runs/3686918469

@erohmensing erohmensing mentioned this pull request Dec 13, 2022
Merged
@bazarnov bazarnov merged commit 4e9b014 into master Dec 13, 2022
@bazarnov bazarnov deleted the baz/fix-cdk-stopiteration branch December 13, 2022 15:54
erohmensing added a commit that referenced this pull request Dec 15, 2022
@erohmensing
Revert "🐛 Python CDK: fix StopIteration error for `check_availabili…
44f93e7 
…ty` (#20429)"

This reverts commit 4e9b014.
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
erohmensing added a commit that referenced this pull request Dec 15, 2022
@erohmensing @octavia-squidington-iii
CDK 0.15.0 and source-github 0.3.10 -- revert AvailabillityStrategy c…
8bb4128 
…hanges (#20523)

* Revert "source-github: move known error handling to GithubAvailabilityStrategy (#19978)"

This reverts commit f97db17.

* Revert "🐛 Python CDK: fix `StopIteration` error for `check_availability` (#20429)"

This reverts commit 4e9b014.

* Revert "CDK: `AbstractSource.read()` skips syncing stream if its unavailable (add `AvailabilityStrategy` concept) (#19977)"

This reverts commit 55a3288.

* Restore changelog entries

* bump CDK version

* Bump Github version

* Re-add removed dependencies

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 18, 2022
Merged
erohmensing pushed a commit that referenced this pull request Dec 27, 2022
@bazarnov @erohmensing
🐛 Python CDK: fix StopIteration error for check_availability (#20429
7c17351 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

@grubberr grubberr grubberr approved these changes

@roman-yermilov-gl roman-yermilov-gl roman-yermilov-gl approved these changes

@brianjlai brianjlai Awaiting requested review from brianjlai

@davydov-d davydov-d Awaiting requested review from davydov-d

@girarda girarda Awaiting requested review from girarda

Assignees

@bazarnov bazarnov

Labels
CDK Connector Development Kit team/connectors-python
Projects
No open projects
GL Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bazarnov @grubberr @erohmensing @roman-yermilov-gl @octavia-squidington-iv