-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDK 0.15.0 and source-github 0.3.10 -- revert AvailabillityStrategy changes #20523
Conversation
/publish-cdk dry-run=true
|
airbyte-cdk/python/setup.py
Outdated
"cachetools", | ||
], | ||
python_requires=">=3.9", | ||
extras_require={ | ||
"dev": [ | ||
"freezegun", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were removed accidentally - they were part of the commits that shouldn't have been reverted. Need to be added back in like the changelog. This was a merge conflict resolution issue. Adding them back in!
/test connector=connectors/source-github
Build PassedTest summary info:
|
/publish connector=connectors/source-github
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Why
We ran into issues especially with substreams interacting with these changes, maybe also API errors that are not strictly HTTPErrors. (Not quite sure, will update this when we've tracked down the issue). Connectors that have CDK versions 0.13.x and 0.14.x installed might run into these issues. We publish a new CDK version so we can build those connectors with 0.15.0.
We publish a new github version with reverted changes so that we can unpin 0.3.8 in the source definition mask on cloud.