Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-20322] updating tutorial documentation #21163

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Jan 9, 2023

What

Updating tutorial documentation following 4f0aca5

@maxi297 maxi297 requested a review from a team as a code owner January 9, 2023 16:36
@octavia-squidington-iv octavia-squidington-iv added area/documentation Improvements or additions to documentation CDK Connector Development Kit labels Jan 9, 2023
@flash1293
Copy link
Contributor

Not a biggie but seems like it still has a legacy value in

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the possible values for cursor granularity described somewhere? I don't see them in https://docs.airbyte.com/connector-development/config-based/understanding-the-yaml-file/stream-slicers

@maxi297 maxi297 merged commit 423cb8b into master Jan 10, 2023
@maxi297 maxi297 deleted the issue-20322_updating-documentation branch January 10, 2023 15:03
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
* [ISSUE-20322] updating tutorial documentation

* [ISSUE-20322] updating test and improving docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants