Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-20322] updating tutorial documentation #21163

Merged
merged 2 commits into from
Jan 10, 2023
Merged

[ISSUE-20322] updating tutorial documentation #21163

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69d8ef6
[ISSUE-20322] updating tutorial documentation
maxi297 Jan 9, 2023
74480ba
[ISSUE-20322] updating test and improving docs
maxi297 Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-cdk/python/airbyte_cdk/sources/declarative/stream_slicers/datetime_stream_slicer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def stream_slices(self, sync_mode: SyncMode, stream_state: Mapping[str, Any]) ->
"""
Partition the daterange into slices of size = step.

The start of the window is the minimum datetime between start_datetime - looback_window and the stream_state's datetime
The start of the window is the minimum datetime between start_datetime - lookback_window and the stream_state's datetime
The end of the window is the minimum datetime between the start of the window and end_datetime.

:param sync_mode:
Expand Down
6 changes: 4 additions & 2 deletions docs/connector-development/config-based/tutorial/5-incremental-reads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,9 @@ definitions:
end_datetime:
datetime: "{{ now_utc() }}"
datetime_format: "%Y-%m-%d %H:%M:%S.%f+00:00"
step: "1d"
step: "P1D"
datetime_format: "%Y-%m-%d"
cursor_granularity: "P1D"
cursor_field: "{{ options['stream_cursor_field'] }}"
```

Expand Down Expand Up @@ -182,8 +183,9 @@ definitions:
end_datetime:
datetime: "{{ now_utc() }}"
datetime_format: "%Y-%m-%d %H:%M:%S.%f+00:00"
step: "1d"
step: "P1D"
datetime_format: "%Y-%m-%d"
cursor_granularity: "P1D"
cursor_field: "{{ options['stream_cursor_field'] }}"
retriever:
record_selector:
Expand Down
2 changes: 1 addition & 1 deletion ...nnector-development/config-based/understanding-the-yaml-file/request-options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ The following example will set the "created[gte]" request parameter value to the
stream_slicer:
start_datetime: "2021-02-01T00:00:00.000000+0000",
end_datetime: "2021-03-01T00:00:00.000000+0000",
step: "1d"
step: "P1D"
start_time_option:
field_name: "created[gte]"
inject_into: "request_parameter"
Expand Down