Add missing info tooltips to new streams table headers #21272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizel852
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Code LGTM 👍
Also tested locally - works as should
Passing to @edmundito for another review
dizel852
requested review from
edmundito
and removed request for
YatsukBogdan1
edmundito
suggested changes
Jan 12, 2023
airbyte-webapp/src/components/connection/CatalogTree/next/CatalogTreeTableHeader.tsx
Outdated
Show resolved
Hide resolved
matter-q
force-pushed
the
mark/add-missing-info-tooltips-to-new-streams-table-headers
branch
2 times, most recently
from
87b492d to
f2d7694
Compare
added 2 commits
January 16, 2023 21:31
- Added info tooltips to the new streams table headers
- Added info tooltips to the new streams table headers
matter-q
force-pushed
the
mark/add-missing-info-tooltips-to-new-streams-table-headers
branch
from
f2d7694 to
8401797
Compare
- Added info tooltips to the new streams table headers
edmundito
approved these changes
Jan 17, 2023
matter-q
deleted the
mark/add-missing-info-tooltips-to-new-streams-table-headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #20451
How
Added info tooltips to the new streams table headers
Fixed minor issues:
For test purposes, use the environment variable: REACT_APP_NEW_STREAMS_TABLE=true
Loom
https://www.loom.com/share/c67fd06ed3da478a9ffbdf6be98839c3