Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing info tooltips to new streams table headers #21272

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,15 @@ export const CatalogTreeTableHeader: React.FC = () => {
</TextCell> */}
<HeaderCell>
<FormattedMessage id="form.namespace" />
<InfoTooltip>
<FormattedMessage id="connectionForm.sourceNamespace.info" />
</InfoTooltip>
</HeaderCell>
<HeaderCell>
<FormattedMessage id="form.streamName" />
<InfoTooltip>
<FormattedMessage id="connectionForm.sourceStreamName.info" />
</InfoTooltip>
</HeaderCell>
<HeaderCell size="large">
<FormattedMessage id="form.syncMode" />
Expand All @@ -104,6 +110,9 @@ export const CatalogTreeTableHeader: React.FC = () => {
</HeaderCell>
<HeaderCell>
<FormattedMessage id="form.primaryKey" />
<InfoTooltip>
<FormattedMessage id="connectionForm.primaryKey.info" />
</InfoTooltip>
</HeaderCell>
<CatalogTreeTableCell size="xsmall" />
<HeaderCell>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

.content {
display: flex;
height: 340px;
height: 360px;
}

.actions,
Expand Down Expand Up @@ -42,4 +42,13 @@
color: colors.$grey;
margin: variables.$spacing-lg 0;
}

.namespaceLink {
margin-top: variables.$spacing-lg;
color: colors.$blue;

.text {
color: colors.$blue;
}
}
}
2 changes: 2 additions & 0 deletions airbyte-webapp/src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@
"connectionForm.cursor.info": "Used in incremental sync mode only. It determines which records to sync.",
"connectionForm.primaryKey.info": "Used in Deduped and History modes only. It determines the unique identifier.",
"connectionForm.source.info": "<b>Stream name</b> is the raw table name from your source.",
"connectionForm.sourceStreamName.info": "<b>Stream name</b> is the raw table name from your source.",
"connectionForm.sourceNamespace.info": "<b>Namespace</b> is the database schema of your source tables.",
"connectionForm.syncType.info": "How data will be replicated from source to destination.",
"connectionForm.destinationName.info": "<b>Namespace</b> is the database schema of your destination tables.",
"connectionForm.destinationStream.info": "<b>Stream name</b> is the final table name in destination.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ import { Text } from "components/ui/Text";
import { ToastType } from "components/ui/Toast";
import { Tooltip } from "components/ui/Tooltip";

import { useNotificationService } from "hooks/services/Notification";
import useWorkspace, { WebhookPayload } from "hooks/services/useWorkspace";
import { links } from "utils/links";

import { useNotificationService } from "../../../../../hooks/services/Notification";
import { Content, SettingsCard } from "../../SettingsComponents";
import help from "./help.png";
import styles from "./WebHookForm.module.scss";
Expand Down