remove airbyte-commons-docker

[colesnodgrass]

What

• part of the repo split work; cleaning up code and dependencies so they won't need to be duplicated
• remove shared library
  • getTaggedImage was simply inserting a : between two strings, replaced with + ":" +
  • buildImage was used in one test class, copied the DockerUtils class to that test class
• Ideally a method getImageTag would be added to the StandardSourceDefinition and StandardDestintationDefinition classes that would return image-tag name, as these classes already know about the repository and the tag. These classes are auto generated and I didn't see a way (in my quick search) to add a derived method attribute like this, as this wouldn't need to be part of the data of the object.

How

• replace calls to shared library with non shared code
• had to add the BouncyCastle dependencies to the airbyte-workers test-implementation dependencies
  • tests started failing with JcaPEMKeyConverter is provided by BouncyCastle, an optional dependency. To use support for EC Keys you must explicitly add this dependency to classpath errors when the airbyte-commons-docker dependency was removed. airbyte-commons-docker didn't depend on BouncyCastle, so I'm guessing this was being brought in via a transitive dependency that airbyte-commons-docker brought with it.

[github-actions]

Airbyte Code Coverage

File	Coverage [78.87%]	🍏
JobErrorReporter.java	100%	🍏
LocalDefinitionsProvider.java	94.85%	🍏
DefaultSyncJobFactory.java	90.06%	🍏
JobCreationAndStatusUpdateActivityImpl.java	88.21%	🍏
CombinedConnectorCatalogGenerator.java	52.29%	❌
GenerateInputActivityImpl.java	1.19%	❌

Total Project Coverage	24.5%	❌

[github-actions]

Kube Test Results

  47 files  ±0    47 suites  ±0   9m 6s ⏱️ - 12m 57s
208 tests ±0  172 ✔️  - 30  36 💤 +30  0 ❌ ±0 
226 runs  ±0  190 ✔️  - 30  36 💤 +30  0 ❌ ±0 

Results for commit 1d17a10. ± Comparison against base commit 1fe3168.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.

io.airbyte.workers.temporal.scheduling.ConnectionManagerWorkflowTest$FailedActivityWorkflow ‑ [1] Thread[Thread-8,5,main]
io.airbyte.workers.temporal.scheduling.ConnectionManagerWorkflowTest$FailedActivityWorkflow ‑ [2] Thread[Thread-9,5,main]
io.airbyte.workers.temporal.scheduling.ConnectionManagerWorkflowTest$FailedActivityWorkflow ‑ [3] Thread[Thread-10,5,main]
io.airbyte.workers.temporal.scheduling.ConnectionManagerWorkflowTest$FailedActivityWorkflow ‑ [4] Thread[Thread-11,5,main]

io.airbyte.workers.temporal.scheduling.ConnectionManagerWorkflowTest$FailedActivityWorkflow ‑ [1] Thread[Thread-6,5,main]
io.airbyte.workers.temporal.scheduling.ConnectionManagerWorkflowTest$FailedActivityWorkflow ‑ [2] Thread[Thread-7,5,main]
io.airbyte.workers.temporal.scheduling.ConnectionManagerWorkflowTest$FailedActivityWorkflow ‑ [3] Thread[Thread-8,5,main]
io.airbyte.workers.temporal.scheduling.ConnectionManagerWorkflowTest$FailedActivityWorkflow ‑ [4] Thread[Thread-9,5,main]

This pull request skips 33 and un-skips 3 tests.

io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testCancelSync()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testCreateConnection()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testCreateDestination()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testCronSync()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testDeleteConnection()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testDestinationCheckConnection()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testDiscoverSourceSchema()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testFailedGet404()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testGetDestinationSpec()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testGetSourceSpec()
…

io.airbyte.test.acceptance.ContainerOrchestratorAcceptanceTests ‑ testCancelSyncWhenCancelledWhenWorkerIsNotRunning()
io.airbyte.test.acceptance.ContainerOrchestratorAcceptanceTests ‑ testCancelSyncWithInterruption()
io.airbyte.test.acceptance.ContainerOrchestratorAcceptanceTests ‑ testDowntimeDuringSync()

♻️ This comment has been updated with latest results.