Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "remove airbyte-commons-docker"" #22239

Merged

Conversation

colesnodgrass
Copy link
Member

@colesnodgrass colesnodgrass commented Feb 1, 2023

Reverts #22237

Will reapply after updating cloud.

This is identical to #21756 but now depends on airbytehq/airbyte-cloud#4315 to be merged first.

@octavia-squidington-iii octavia-squidington-iii added area/platform issues related to the platform area/server area/worker Related to worker labels Feb 1, 2023
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 1, 2023 20:46 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 1, 2023 20:46 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Airbyte Code Coverage

File Coverage [78.87%] 🍏
JobErrorReporter.java 100% 🍏
LocalDefinitionsProvider.java 94.85% 🍏
DefaultSyncJobFactory.java 90.06% 🍏
JobCreationAndStatusUpdateActivityImpl.java 88.21% 🍏
CombinedConnectorCatalogGenerator.java 52.29%
GenerateInputActivityImpl.java 1.19%
Total Project Coverage 24.54%

@colesnodgrass colesnodgrass marked this pull request as ready for review February 1, 2023 20:59
@colesnodgrass colesnodgrass requested a review from a team as a code owner February 1, 2023 20:59
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 6, 2023 19:17 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 6, 2023 19:18 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass merged commit f098287 into master Feb 6, 2023
@colesnodgrass colesnodgrass deleted the revert-22237-revert-21756-cole/rem-commons-docker branch February 6, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/server area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants