-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Hubspot: enable SAT high strictness #21775
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2d0d5b3
Source Hubspot: enable SAT high strictness
arsenlosenko a1187eb
Ignore stream companies for basic read because one of the fields are …
arsenlosenko 23b0100
Ignore streams that change often
arsenlosenko d6afaea
Remove contacts stream from empty_streams
arsenlosenko c3f3406
Updated expected records
lazebnyi 89917e9
Merge branch 'master' into arsenlosenko/source-hubspot-high-strictness
lazebnyi 6f8af3a
Merge branch 'master' into arsenlosenko/source-hubspot-high-strictness
lazebnyi 2ed0dd6
add not empty streams to expected records
lazebnyi 1598d3e
Updated expacted records
lazebnyi c05909e
Added allowedHosts
lazebnyi 4144a24
Skiped property_history stream for basic read
lazebnyi 7e99801
Merge branch 'master' into arsenlosenko/source-hubspot-high-strictness
lazebnyi e33f9f5
Resolve packages dependecy conflict
lazebnyi 5485d89
Merge master to branch
lazebnyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
132 changes: 55 additions & 77 deletions
132
airbyte-integrations/connectors/source-hubspot/acceptance-test-config.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,91 +1,69 @@ | ||
| connector_image: airbyte/source-hubspot:dev | ||
| test_strictness_level: high | ||
| acceptance_tests: | ||
| spec: | ||
| tests: | ||
| - spec_path: "source_hubspot/spec.yaml" | ||
| backward_compatibility_tests_config: | ||
| # API Key authentication is deleted from authorization choices so it is not backward compatible with previous spec | ||
| disable_for_version: "0.2.3" | ||
| - spec_path: source_hubspot/spec.yaml | ||
| connection: | ||
| tests: | ||
| - config_path: "secrets/config.json" | ||
| status: "succeed" | ||
| - config_path: "integration_tests/invalid_config.json" | ||
| status: "failed" | ||
| - config_path: "integration_tests/invalid_config_oauth.json" | ||
| status: "failed" | ||
| - config_path: "integration_tests/invalid_config_wrong_title.json" | ||
| status: "failed" | ||
| - config_path: secrets/config_oauth.json | ||
| status: succeed | ||
| - config_path: integration_tests/invalid_config.json | ||
| status: failed | ||
| - config_path: integration_tests/invalid_config_oauth.json | ||
| status: failed | ||
| - config_path: integration_tests/invalid_config_wrong_title.json | ||
| status: failed | ||
| discovery: | ||
| tests: | ||
| - config_path: "secrets/config.json" | ||
| backward_compatibility_tests_config: | ||
| # Quote stream is deleted so it is not backward compatible with previous discovery | ||
| disable_for_version: "0.2.3" | ||
| - config_path: secrets/config_oauth.json | ||
| basic_read: | ||
| tests: | ||
| - config_path: "secrets/config.json" | ||
| timeout_seconds: 600 | ||
| configured_catalog_path: "sample_files/basic_read_oauth_catalog.json" | ||
| - config_path: secrets/config_oauth.json | ||
| empty_streams: | ||
| - name: "form_submissions" | ||
| bypass_reason: "unable to populate" | ||
| - name: "form_submissions" | ||
| bypass_reason: "unable to populate" | ||
| - name: "ticket_pipelines" | ||
| bypass_reason: "unable to populate" | ||
| - name: "engagements_meetings" | ||
| bypass_reason: "unable to populate" | ||
| - name: "engagements_emails" | ||
| bypass_reason: "unable to populate" | ||
| - name: "engagements" | ||
| bypass_reason: "unable to populate" | ||
| - name: "engagements_calls" | ||
| bypass_reason: "unable to populate" | ||
| - name: "quotes" | ||
| bypass_reason: "unable to populate" | ||
| # This test commented out, since it produces errors during active testing | ||
| # expect_records: | ||
| # path: "integration_tests/expected_records.jsonl" | ||
| incremental: | ||
| tests: | ||
| - config_path: "secrets/config.json" | ||
| configured_catalog_path: "sample_files/incremental_catalog.json" | ||
| future_state: | ||
| future_state_path: "integration_tests/abnormal_state.json" | ||
| - name: property_history | ||
| bypass_reason: has randomly calculated records | ||
| - name: form_submissions | ||
| bypass_reason: unable to populate | ||
| - name: ticket_pipelines | ||
| bypass_reason: unable to populate | ||
| - name: engagements_meetings | ||
| bypass_reason: unable to populate | ||
| - name: engagements_emails | ||
| bypass_reason: unable to populate | ||
| - name: engagements_calls | ||
| bypass_reason: unable to populate | ||
| - name: quotes | ||
| bypass_reason: unable to populate | ||
| timeout_seconds: 3600 | ||
| expect_records: | ||
| path: integration_tests/expected_records.jsonl | ||
| exact_order: yes | ||
| extra_fields: yes | ||
| extra_records: no | ||
| full_refresh: | ||
| tests: | ||
| - config_path: "secrets/config.json" | ||
| configured_catalog_path: "sample_files/full_refresh_oauth_catalog.json" | ||
| - config_path: secrets/config_oauth.json | ||
| configured_catalog_path: sample_files/full_refresh_oauth_catalog.json | ||
| ignored_fields: | ||
| "contact_lists": [ "properties", "ilsFilterBranch" ] | ||
| "companies": [ "properties", "hs_time_in_customer" ] | ||
| "companies": [ "properties", "hs_time_in_evangelist" ] | ||
| "companies": [ "properties", "hs_time_in_lead" ] | ||
| "companies": [ "properties", "hs_time_in_marketingqualifiedlead" ] | ||
| "companies": [ "properties", "hs_time_in_opportunity" ] | ||
| "companies": [ "properties", "hs_time_in_other" ] | ||
| "companies": [ "properties", "hs_time_in_salesqualifiedlead" ] | ||
| "companies": [ "properties", "hs_time_in_subscriber" ] | ||
| "contacts": [ "properties", "hs_time_in_customer" ] | ||
| "contacts": [ "properties", "hs_time_in_evangelist" ] | ||
| "contacts": [ "properties", "hs_time_in_lead" ] | ||
| "contacts": [ "properties", "hs_time_in_marketingqualifiedlead" ] | ||
| "contacts": [ "properties", "hs_time_in_opportunity" ] | ||
| "contacts": [ "properties", "hs_time_in_other" ] | ||
| "contacts": [ "properties", "hs_time_in_salesqualifiedlead" ] | ||
| "contacts": [ "properties", "hs_time_in_subscriber" ] | ||
| "deals": [ "properties", "hs_time_in_9567448" ] | ||
| "deals": [ "properties", "hs_time_in_9567449" ] | ||
| "deals": [ "properties", "hs_time_in_appointmentscheduled" ] | ||
| "deals": [ "properties", "hs_time_in_closedlost" ] | ||
| "deals": [ "properties", "hs_time_in_closedwon" ] | ||
| "deals": [ "properties", "hs_time_in_contractsent" ] | ||
| "deals": [ "properties", "hs_time_in_customclosedwonstage" ] | ||
| "deals": [ "properties", "hs_time_in_decisionmakerboughtin" ] | ||
| "deals": [ "properties", "hs_time_in_presentationscheduled" ] | ||
| "deals": [ "properties", "hs_time_in_qualifiedtobuy" ] | ||
| "tickets": [ "properties", "hs_time_in_1" ] | ||
| "tickets": [ "properties", "hs_time_in_2" ] | ||
| "tickets": [ "properties", "hs_time_in_3" ] | ||
| "tickets": [ "properties", "hs_time_in_4" ] | ||
| companies: | ||
| - properties | ||
| - hs_time_in_subscriber | ||
| contact_lists: | ||
| - properties | ||
| - ilsFilterBranch | ||
| contacts: | ||
| - properties | ||
| - hs_time_in_subscriber | ||
| deals: | ||
| - properties | ||
| - hs_time_in_qualifiedtobuy | ||
| tickets: | ||
| - properties | ||
| - hs_time_in_4 | ||
| incremental: | ||
| tests: | ||
| - config_path: secrets/config_oauth.json | ||
| configured_catalog_path: sample_files/incremental_catalog.json | ||
| future_state: | ||
| future_state_path: integration_tests/abnormal_state.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 allowedhosts!