Source Hubspot: enable SAT high strictness #21775

arsenlosenko · 2023-01-24T10:28:34Z

What

Resolving:
#19048

How

Updating SAT config and expected records.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

arsenlosenko · 2023-01-24T10:29:21Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3995254652
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3995254652
🐛 https://gradle.com/s/z2snwl7vh2hge

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream compa...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 30 passed, 2 skipped in 242.03s (0:04:02) ==============

…constantly changing

arsenlosenko · 2023-01-24T11:41:33Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3995815209
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3995815209
🐛 https://gradle.com/s/6sgxtu6peij6e

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 30 passed, 2 skipped in 241.60s (0:04:01) ==============

arsenlosenko · 2023-01-25T20:06:48Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4009548540
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4009548540
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70     10    86%
source_hubspot/source.py         90     23    74%
source_hubspot/streams.py       837    269    68%
-------------------------------------------------
TOTAL                          1007    302    70%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       837     77    91%
source_hubspot/source.py         90     18    80%
-------------------------------------------------
TOTAL                          1007     98    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 31 passed, 2 skipped in 278.99s (0:04:38) ===================

evantahler · 2023-01-25T20:44:41Z

airbyte-integrations/connectors/source-hubspot/acceptance-test-config.yml

+      - name: companies
+        bypass_reason: hs_time_in_opportunity field changes after every read
+      - name: contacts
+        bypass_reason: data is changing after every read


At least these 2 streams should have consistent data - what's changing?

I am currently checking expected records for these two streams, when I was running SAT tests locally yesterday I had problems with inconsistent records, but let me double check again just in case

I have checked the data for these two streams, removed contacts stream as it indeed has consistent data, last test run failed due to some issues from API side (maybe some kind of a rate limit), will re-run them later or investigate what may cause this failed run

arsenlosenko · 2023-01-27T15:47:52Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4026008303
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4026008303
🐛 https://gradle.com/s/jhd5vtohycppi

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 5 failed, 26 passed, 2 skipped in 783.83s (0:13:03) ==============

arsenlosenko · 2023-01-27T20:47:54Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4028067690
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4028067690
🐛 https://gradle.com/s/ynn2wfsxeayk4

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 30 passed, 2 skipped in 263.99s (0:04:23) ==============

arsenlosenko · 2023-01-29T10:40:12Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4036381163
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4036381163
🐛 https://gradle.com/s/zmnfmynnfcqzq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 30 passed, 2 skipped in 232.86s (0:03:52) ==============

lazebnyi · 2023-01-31T01:59:23Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4049980093
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4049980093
🐛 https://gradle.com/s/nondrip65y4aq

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 31 passed, 2 skipped in 240.36s (0:04:00) ===================

lazebnyi · 2023-01-31T09:15:01Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4052514881
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4052514881
🐛 https://gradle.com/s/n5nqbmn6uyryw

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 220.66s (0:03:40) ===================

lazebnyi · 2023-01-31T15:45:46Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4055798837
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4055798837
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70     10    86%
source_hubspot/source.py         90     23    74%
source_hubspot/streams.py       841    269    68%
-------------------------------------------------
TOTAL                          1011    302    70%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       841     78    91%
source_hubspot/source.py         90     18    80%
-------------------------------------------------
TOTAL                          1011     99    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 295.30s (0:04:55) ===================

lazebnyi · 2023-02-02T14:50:36Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4075667097
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4075667097
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70     10    86%
source_hubspot/source.py         90     23    74%
source_hubspot/streams.py       841    269    68%
-------------------------------------------------
TOTAL                          1011    302    70%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       841     78    91%
source_hubspot/source.py         90     18    80%
-------------------------------------------------
TOTAL                          1011     99    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 269.25s (0:04:29) ===================

lazebnyi · 2023-02-02T15:35:24Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4076077332
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4076077332
🐛 https://gradle.com/s/ttp6p2ou5dq3e

Build Failed

Test summary info:

Could not find result summary

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4076077332
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4076077332
🐛 https://gradle.com/s/p5to3q2hebxtm

Build Failed

Test summary info:

Could not find result summary

lazebnyi · 2023-02-02T22:26:55Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4079213670
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4079213670
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       841     78    91%
source_hubspot/source.py         90     18    80%
-------------------------------------------------
TOTAL                          1011     99    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70     10    86%
source_hubspot/source.py         90     23    74%
source_hubspot/streams.py       841    269    68%
-------------------------------------------------
TOTAL                          1011    302    70%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 245.27s (0:04:05) ===================

github-actions · 2023-02-02T22:27:01Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.52%	❌

evantahler

Thanks!

evantahler · 2023-02-02T23:21:50Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

+  allowedHosts:
+    hosts:
+      - api.hubapi.com


👍 allowedhosts!

Source Hubspot: enable SAT high strictness

2d0d5b3

arsenlosenko self-assigned this Jan 24, 2023

octavia-squidington-iv added area/connectors Connector related issues connectors/source/hubspot labels Jan 24, 2023

arsenlosenko linked an issue Jan 24, 2023 that may be closed by this pull request

Source HubSpot: enable high test strictness level in SAT #19048

Closed

Ignore stream companies for basic read because one of the fields are …

a1187eb

…constantly changing

Ignore streams that change often

23b0100

arsenlosenko marked this pull request as ready for review January 25, 2023 20:34

arsenlosenko requested review from darynaishchenko and lazebnyi January 25, 2023 20:34

lazebnyi approved these changes Jan 25, 2023

View reviewed changes

arsenlosenko requested a review from evantahler January 25, 2023 20:38

evantahler reviewed Jan 25, 2023

View reviewed changes

evantahler mentioned this pull request Jan 25, 2023

[SAT] ignored_fields key for basic read test #21737

Closed

lazebnyi requested a review from evantahler January 26, 2023 16:49

Remove contacts stream from empty_streams

d6afaea

Updated expected records

c3f3406

lazebnyi self-assigned this Jan 31, 2023

Merge branch 'master' into arsenlosenko/source-hubspot-high-strictness

89917e9

Merge branch 'master' into arsenlosenko/source-hubspot-high-strictness

6f8af3a

lazebnyi requested a review from alafanechere January 31, 2023 19:00

Added allowedHosts

c05909e

lazebnyi temporarily deployed to more-secrets February 2, 2023 14:49 — with GitHub Actions Inactive

Skiped property_history stream for basic read

4144a24

lazebnyi temporarily deployed to more-secrets February 2, 2023 14:52 — with GitHub Actions Inactive

Merge branch 'master' into arsenlosenko/source-hubspot-high-strictness

7e99801

lazebnyi temporarily deployed to more-secrets February 2, 2023 15:19 — with GitHub Actions Inactive

lazebnyi temporarily deployed to more-secrets February 2, 2023 15:39 — with GitHub Actions Inactive

lazebnyi added 2 commits February 2, 2023 23:15

Resolve packages dependecy conflict

e33f9f5

Merge master to branch

5485d89

lazebnyi temporarily deployed to more-secrets February 2, 2023 22:18 — with GitHub Actions Inactive

lazebnyi requested a review from evantahler February 2, 2023 22:42

evantahler approved these changes Feb 2, 2023

View reviewed changes

lazebnyi merged commit dfdec66 into master Feb 6, 2023

lazebnyi deleted the arsenlosenko/source-hubspot-high-strictness branch February 6, 2023 22:11

github-actions bot mentioned this pull request Feb 7, 2023

Bump helm chart version reference to 0.43.28 #22489

Closed

octavia-squidington-iii mentioned this pull request Feb 8, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22578

Closed

grubberr mentioned this pull request Feb 8, 2023

Source Hubspot: turn on default HttpAvailabilityStrategy #22479

Merged

14 tasks

This was referenced Feb 10, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Hubspot: enable SAT high strictness #21775

Source Hubspot: enable SAT high strictness #21775

arsenlosenko commented Jan 24, 2023

arsenlosenko commented Jan 24, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 24, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 25, 2023 •

edited by github-actions bot

Loading

evantahler Jan 25, 2023

arsenlosenko Jan 26, 2023

arsenlosenko Jan 27, 2023

arsenlosenko commented Jan 27, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 27, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 29, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 31, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 31, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 31, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Feb 2, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Feb 2, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Feb 2, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 2, 2023

evantahler left a comment

evantahler Feb 2, 2023

Source Hubspot: enable SAT high strictness #21775

Source Hubspot: enable SAT high strictness #21775

Conversation

arsenlosenko commented Jan 24, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

arsenlosenko commented Jan 24, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Jan 24, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Jan 25, 2023 • edited by github-actions bot Loading

Build Passed

evantahler Jan 25, 2023

Choose a reason for hiding this comment

arsenlosenko Jan 26, 2023

Choose a reason for hiding this comment

arsenlosenko Jan 27, 2023

Choose a reason for hiding this comment

arsenlosenko commented Jan 27, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Jan 27, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Jan 29, 2023 • edited by github-actions bot Loading

Build Failed

lazebnyi commented Jan 31, 2023 • edited by github-actions bot Loading

Build Passed

lazebnyi commented Jan 31, 2023 • edited by github-actions bot Loading

Build Passed

lazebnyi commented Jan 31, 2023 • edited by github-actions bot Loading

Build Passed

lazebnyi commented Feb 2, 2023 • edited by github-actions bot Loading

Build Passed

lazebnyi commented Feb 2, 2023 • edited by github-actions bot Loading

Build Failed

Build Failed

lazebnyi commented Feb 2, 2023 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Feb 2, 2023

Airbyte Code Coverage

evantahler left a comment

Choose a reason for hiding this comment

evantahler Feb 2, 2023

Choose a reason for hiding this comment

arsenlosenko commented Jan 24, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 24, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 25, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 27, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 27, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 29, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 31, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 31, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 31, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Feb 2, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Feb 2, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Feb 2, 2023 •

edited by github-actions bot

Loading