Revert allowedHosts missing value checks
#21923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
pedroslopez
approved these changes
Jan 26, 2023
benmoriceau
approved these changes
Jan 26, 2023
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
changed the title
allowedHosts missing value checks
Airbyte Code Coverage
|
pgollangi
pushed a commit
to pgollangi/airbyte
that referenced
this pull request
Jan 26, 2023
This was referenced Jan 27, 2023
archangelic
added a commit
that referenced
this pull request
Apr 27, 2023
* feat: source-gitlab accept api_url w/ or w/o scheme * 🪟🔧 Refactor ConnectorsView (#21531) * WIP * WIP * wip * more fixes * fix test * remove some more styled components and improve memoization * review comment * feat: source-gitlab accept api_url w/ or w/o scheme * Revert allowedHosts missing value checks (#21923) * bump versions * update expected records * auto-bump connector version --------- Co-authored-by: Joe Reuter <joe@airbyte.io> Co-authored-by: Evan Tahler <evan@airbyte.io> Co-authored-by: Mal Hancock <mallory@archangelic.space> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
marcosmarxm
added a commit
to natalia-miinto/airbyte
that referenced
this pull request
Jun 8, 2023
* feat: source-gitlab accept api_url w/ or w/o scheme * 🪟🔧 Refactor ConnectorsView (airbytehq#21531) * WIP * WIP * wip * more fixes * fix test * remove some more styled components and improve memoization * review comment * feat: source-gitlab accept api_url w/ or w/o scheme * Revert allowedHosts missing value checks (airbytehq#21923) * bump versions * update expected records * auto-bump connector version --------- Co-authored-by: Joe Reuter <joe@airbyte.io> Co-authored-by: Evan Tahler <evan@airbyte.io> Co-authored-by: Mal Hancock <mallory@archangelic.space> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21676 introduced a check to ensure that the interpolated values required for allowedHosts from connector configs was present, and threw an error if missing. This caused on call errors (https://github.com/airbytehq/oncall/issues/1373).
This PR removes that check as we aren't yet requiring this data to build the firewalls. A deeper analysis of the problem will be done in #21921