-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AllowedHosts
for all Database Sources
#22372
Comments
Hello @evantahler I would like to work on this. |
AllowedHosts
for all Database Sources
I seem to remember manybe we had an OC issue with allowed hosts a while back. Am I crazy @evantahler ? Just want to make sure not to mess it up. |
There was a platform-level OC issue (#21923) which was due to the weirdness that is a reset-connection. Adding these values for a connector, even if they are wrong, shouldn't break anything in production. The path to ensuring your allowedHosts entries are properly interpolating config information is to look at the logs when the containers boot. Look for a log line that interpolates the allowedHosts properly. This is the failure case:
More information @ #21950 |
Work done: PR reviewed for non-GA source connectors.
|
Plan to publish all database connectors early next week. |
Done for all DB Sources except MongoDB, Redshift and Azure Table DB Source because of previously failing integration tests. Moving this to blocked/hold lane until we fix these tests and get them in a publishable state. Issue created for tracking publish https://github.com/airbytehq/airbyte-internal-issues/issues/2714 |
As part of the network isolation epic, all connectors will need to provide which hosts the connector container will be granted access to.
For databases, this information is dynamic and read from the connector's config. It probably looks a lot like:
airbyte/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
Lines 1370 to 1373 in e6441bf
This information is to be added to the actor_definitions. A re-publish of the connector is not required.
The text was updated successfully, but these errors were encountered: