-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support config sub-values for allowedHosts
#21950
Conversation
allowedHosts: | ||
hosts: | ||
- "${host}" | ||
- "${tunnel_method.tunnel_host}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @bleonard / @prateekmukhedkar - this should be the complete set of needs for source-postgres!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evantahler I am working on adding allowedHosts
to the remaining database sources(link). Reading through this PR, it appears that ${tunnel_method.tunnel_host}
is only required for those sources that support connection via SSH tunnels. (for example as of now we don't support connecting via ssh for source-redshift). And for all such sources I will only include ${host}
sub-value under allowedHosts
. Does that sound correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
Airbyte Code Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, makes sense!
Following #21676 and closes #21913, this PR adds support for allowedHosts that come from sub-keys in the connector's configuration.
For example, configs for postgres sources which use SSH tunnels might look like:
Which means allowedHosts should support both
host
andtunnel_method.tunnel_host
.