Add a feature flag for a failure because of an heartbeat failed check #22036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmoriceau
requested review from
colesnodgrass,
jdpgrailsdev,
gosusnp and
alovew
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
Airbyte Code Coverage
|
colesnodgrass
approved these changes
Jan 27, 2023
configs/flags.yml
Outdated
| @@ -1,3 +1,5 @@ | |||
| flags: | |||
| - name: performance.backgroundJsonSchemaValidation | |||
| enabled: true | |||
| - name: heartbeat.fail_sync | |||
There was a problem hiding this comment.
The docs are up yet, but the existing feature-flags are all camelCased. Could we camelCase this one for consistency?
…rce-hearbeat-feature-flags
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
|
@benmoriceau heads-up that the |
|
@colesnodgrass could you review the flag in LD? https://app.launchdarkly.com/default/production/features/heartbeat.failSync/targeting It is the first one, I'm creating and I would like to make sure that I didn't do a mistake. |
…rce-hearbeat-feature-flags
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
…airbytehq#22036) * Add a feature flag for a failure because of an heartbeat failed check * Use Camel case * Add missing new line * Checkout From master
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a feature flag that will then be used to protect jobs from failing because of a missed heartbeat.