Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature flag for a failure because of an heartbeat failed check #22036

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Add a feature flag for a failure because of an heartbeat failed check #22036

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
95d1acc
Add a feature flag for a failure because of an heartbeat failed check
benmoriceau Jan 27, 2023
f24f8af
Use Camel case
benmoriceau Jan 31, 2023
7cc727f
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/sou…
benmoriceau Jan 31, 2023
b3fb3d8
Add missing new line
benmoriceau Jan 31, 2023
9d2fd40
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/sou…
benmoriceau Feb 6, 2023
5c57c3d
Checkout From master
benmoriceau Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airbyte-featureflag/src/main/kotlin/Flags.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ object FieldSelectionWorkspaces : EnvVar(envVar = "FIELD_SELECTION_WORKSPACES")
}
}

object ShouldFailSyncIfHeartbeatFailure : Temporary(key = "heartbeat.fail_sync")

/**
* Flag is a sealed class that all feature-flags must inherit from.
*
Expand Down
2 changes: 2 additions & 0 deletions configs/flags.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
flags:
- name: performance.backgroundJsonSchemaValidation
enabled: true
- name: heartbeat.fail_sync
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are up yet, but the existing feature-flags are all camelCased. Could we camelCase this one for consistency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

enabled: false