Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: set new attribute #22114

Merged
merged 11 commits into from
Feb 9, 2023
Merged

Helm: set new attribute #22114

merged 11 commits into from
Feb 9, 2023

Conversation

franviera92
Copy link
Contributor

I would like to set the following values with helm, I see that it can be set with kustomize but not with helm

@marcosmarxm marcosmarxm requested a review from xpuska513 February 2, 2023 08:44
@marcosmarxm
Copy link
Member

@xpuska513 can you review this contribution?

@marcosmarxm marcosmarxm changed the title set new helm attribute Helm: set new attribute Feb 2, 2023
charts/airbyte/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@xpuska513 xpuska513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosmarxm marcosmarxm enabled auto-merge (squash) February 9, 2023 14:58
@marcosmarxm marcosmarxm merged commit 39402c1 into airbytehq:master Feb 9, 2023
mfsiega-airbyte added a commit that referenced this pull request Feb 10, 2023
mfsiega-airbyte added a commit that referenced this pull request Feb 10, 2023
sh4sh pushed a commit that referenced this pull request Feb 10, 2023
* set new helm attribute

* change to camelCase

---------

Co-authored-by: Kyryl Skobylko <xpuska513@gmail.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants