Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: set new attribute #22114

Merged
merged 11 commits into from
Feb 9, 2023
Merged

Helm: set new attribute #22114

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fda8e55
set new helm attribute
franviera92 Jan 30, 2023
1b46b04
Merge branch 'master' into master
franviera92 Jan 31, 2023
91e6c97
Merge branch 'master' into master
franviera92 Jan 31, 2023
ba6b068
Merge branch 'master' into master
franviera92 Feb 2, 2023
f6cfff9
change to camelCase
franviera92 Feb 2, 2023
a5123fe
Merge branch 'master' into master
franviera92 Feb 7, 2023
fcea02a
Merge branch 'master' into master
franviera92 Feb 7, 2023
a5de12d
Merge branch 'master' into master
xpuska513 Feb 7, 2023
208fbc2
Merge branch 'master' into master
franviera92 Feb 8, 2023
3a78082
Merge branch 'master' into master
marcosmarxm Feb 9, 2023
cc44799
Merge branch 'master' into master
franviera92 Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions charts/airbyte/templates/env-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ data:
{{- end }}
JOBS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION: "0.29.15.001"
LOCAL_ROOT: /tmp/airbyte_local
RUN_DATABASE_MIGRATION_ON_STARTUP: "true"
RUN_DATABASE_MIGRATION_ON_STARTUP: {{ .Values.airbyte-bootloader.run_database_migrations_on_startup | default "true" }}
S3_LOG_BUCKET: {{ .Values.global.logs.s3.bucket | quote }}
S3_LOG_BUCKET_REGION: {{ .Values.global.logs.s3.bucketRegion | quote }}
S3_MINIO_ENDPOINT: {{ include "airbyte.minio.endpoint" . | quote }}
Expand All @@ -58,9 +58,9 @@ data:
WORKSPACE_ROOT: /workspace
METRIC_CLIENT: {{ .Values.global.metrics.metricClient | default "" | quote }}
OTEL_COLLECTOR_ENDPOINT: {{ .Values.global.metrics.otelCollectorEndpoint | default "" | quote }}
ACTIVITY_MAX_ATTEMPT: ""
ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS: ""
ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS: ""
ACTIVITY_MAX_ATTEMPT: {{ .Values.worker.activity_max_attempt | default "" }}
ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS: {{ .Values.worker.activity_initial_delay_between_attempts_seconds | default "" }}
ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS: {{ .Values.worker.activity_max_delay_between_attempts_seconds | default "" }}
WORKFLOW_FAILURE_RESTART_DELAY_SECONDS: ""
USE_STREAM_CAPABLE_STATE: "true"
AUTO_DETECT_SCHEMA: "true"
Expand All @@ -71,5 +71,5 @@ data:
WORKER_LOGS_STORAGE_TYPE: {{ .Values.global.logs.storage.type | quote }}
WORKER_STATE_STORAGE_TYPE: {{ .Values.global.state.storage.type | quote }}
SHOULD_RUN_NOTIFY_WORKFLOWS: "false"
MAX_NOTIFY_WORKERS: "5"
MAX_NOTIFY_WORKERS: {{ .Values.worker.max_notify_workers | default "5" }}
{{- end }}
8 changes: 8 additions & 0 deletions charts/airbyte/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,6 +819,11 @@ worker:
enabled: true
image: ""

## current no exist documentations
activity_max_attempt: ""
activity_initial_delay_between_attempts_seconds: ""
activity_max_delay_between_attempts_seconds: ""
marcosmarxm marked this conversation as resolved.
Show resolved Hide resolved

## @section Metrics parameters
metrics:
enabled: false
Expand Down Expand Up @@ -1057,6 +1062,9 @@ airbyte-bootloader:
##
extraVolumes: []

## run database migrations on startup true|false
run_database_migrations_on_startup: "true"

## @section Temporal parameters
## TODO: Move to consuming temporal from a dedicated helm chart

Expand Down
7 changes: 7 additions & 0 deletions charts/airbyte/values.yaml.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,10 @@ worker:
enabled: true
image: ""

activity_max_attempt: ""
activity_initial_delay_between_attempts_seconds: ""
activity_max_delay_between_attempts_seconds: ""

## @section Metrics parameters
metrics:
enabled: false
Expand Down Expand Up @@ -1045,6 +1049,9 @@ airbyte-bootloader:
##
extraVolumes: []

## run database migrations on startup true|false
run_database_migrations_on_startup: "true"

## @section Temporal parameters
## TODO: Move to consuming temporal from a dedicated helm chart

Expand Down