Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Destination Databend: upgrade databend-sqlalchemy dependency #22855

Closed
wants to merge 9 commits into from

Conversation

hantmac
Copy link
Contributor

@hantmac hantmac commented Feb 11, 2023

What

Describe what the change is solving
Because the 'databend` has some break changes from v0.9.0 and the databend cloud will only use the version > 0.9.0, so we update the databend-py driver to fix compatibility issue with databend-query 0.9 in this pr.

How

Describe the solution
If databend version >= v0.9.0 or later, users need to use databend-sqlalchemy version >= v0.1.0 and I set the version of databend-sqlalchemy as 0.1.0 in setup.py.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 11, 2023
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commits from your pull request and after request my review again.

@octavia-squidington-iii octavia-squidington-iii removed area/frontend Related to the Airbyte webapp area/worker Related to worker labels Feb 14, 2023
@octavia-squidington-iii octavia-squidington-iii removed area/platform issues related to the platform kubernetes labels Feb 14, 2023
@marcosmarxm
Copy link
Member

marcosmarxm commented Feb 14, 2023

/test connector=connectors/destination-databend

🕑 connectors/destination-databend https://github.com/airbytehq/airbyte/actions/runs/4178623546
✅ connectors/destination-databend https://github.com/airbytehq/airbyte/actions/runs/4178623546
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
destination_databend/client.py           12      0   100%
destination_databend/__init__.py          2      0   100%
destination_databend/destination.py      43      2    95%
destination_databend/writer.py           48      5    90%
---------------------------------------------------------
TOTAL                                   105      7    93%

Build Passed

Test summary info:

All Passed

@natalyjazzviolin natalyjazzviolin changed the title fix: upgrade databend-sqlalchemy 🐛 Destination Databend: upgrade databend-sqlalchemy dependency Feb 24, 2023
@hantmac
Copy link
Contributor Author

hantmac commented Mar 8, 2023

/test connector=connectors/destination-databend

@natalyjazzviolin
Copy link
Contributor

natalyjazzviolin commented Mar 23, 2023

/test connector=connectors/destination-databend

🕑 connectors/destination-databend https://github.com/airbytehq/airbyte/actions/runs/4501285219
✅ connectors/destination-databend https://github.com/airbytehq/airbyte/actions/runs/4501285219
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
destination_databend/client.py           12      0   100%
destination_databend/__init__.py          2      0   100%
destination_databend/destination.py      43      2    95%
destination_databend/writer.py           48      5    90%
---------------------------------------------------------
TOTAL                                   105      7    93%

Build Passed

Test summary info:

All Passed

@natalyjazzviolin
Copy link
Contributor

Closing this in favor of #24399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/destination/databend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants