-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Destination Databend: upgrade databend-sqlalchemy dependency #22855
Conversation
be69a52
to
5d3ba3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the commits from your pull request and after request my review again.
airbyte-commons-server/src/main/java/io/airbyte/commons/server/handlers/SchedulerHandler.java
Outdated
Show resolved
Hide resolved
5d3ba3d
to
6ad7ab7
Compare
6ad7ab7
to
ebc0b40
Compare
/test connector=connectors/destination-databend
Build PassedTest summary info:
|
/test connector=connectors/destination-databend |
/test connector=connectors/destination-databend
Build PassedTest summary info:
|
Closing this in favor of #24399 |
What
Describe what the change is solving
Because the 'databend` has some break changes from v0.9.0 and the databend cloud will only use the version > 0.9.0, so we update the databend-py driver to fix compatibility issue with databend-query 0.9 in this pr.
How
Describe the solution
If databend version >= v0.9.0 or later, users need to use databend-sqlalchemy version >= v0.1.0 and I set the version of
databend-sqlalchemy
as0.1.0
insetup.py
.