Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[non-forked] 🐛 Destination Databend: upgrade databend-sqlalchemy dependency #23453

Closed
wants to merge 8 commits into from

Conversation

natalyjazzviolin
Copy link
Contributor

@natalyjazzviolin natalyjazzviolin commented Feb 24, 2023

What

Non-forked branch of #22855 to check the build.

Because the 'databend` has some break changes from v0.9.0 and the databend cloud will only use the version > 0.9.0, so we update the databend-py driver to fix compatibility issue with databend-query 0.9 in databendlabs/databend-py#2.

How

If databend version >= v0.9.0 or later, users need to use databend-sqlalchemy version >= v0.1.0 and I set the version of databend-sqlalchemy as 0.1.0 in setup.py.

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/databend labels Feb 24, 2023
@natalyjazzviolin natalyjazzviolin changed the title DO NOT MERGE non-forked PR #22855 [non-forked] 🐛 Destination Databend: upgrade databend-sqlalchemy dependency Feb 28, 2023
@natalyjazzviolin

This comment was marked as outdated.

@natalyjazzviolin
Copy link
Contributor Author

natalyjazzviolin commented Feb 28, 2023

/test connector=connectors/destination-databend

🕑 connectors/destination-databend https://github.com/airbytehq/airbyte/actions/runs/4296400434
❌ connectors/destination-databend https://github.com/airbytehq/airbyte/actions/runs/4296400434
🐛 https://gradle.com/s/lzuqrsgibz7jc

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/integration_test.py::test_check_valid_config - Asser...
	 FAILED integration_tests/integration_test.py::test_write - databend_py.errors...
	 �[31m========================= �[31m�[1m2 failed�[0m, �[32m1 passed�[0m�[31m in 4.23s�[0m�[31m ==========================�[0m

@hantmac
Copy link
Contributor

hantmac commented Mar 8, 2023

@natalyjazzviolin Hi, would you like to help me upgrade the databend-sqlalchemy to 0.1.6? I have modified it in this pr #22855.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/databend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants