-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: Captain Data [Configuration based CDK] #25230
🎉 New Source: Captain Data [Configuration based CDK] #25230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments @elliottrabac thanks for the contribution
airbyte-integrations/connectors/source-captain-data/source_captain_data/manifest.yaml
Outdated
Show resolved
Hide resolved
...yte-integrations/connectors/source-captain-data/source_captain_data/schemas/job_results.json
Show resolved
Hide resolved
airbyte-integrations/connectors/source-captain-data/source_captain_data/schemas/workflows.json
Outdated
Show resolved
Hide resolved
@marcosmarxm thanks for the review. I updated the PR 👍 |
bumping this @marcosmarxm 🙏 |
@marcosmarxm 🙏 Any chance to have a quick review here? |
@elliottrabac sure! we're going to review this week! |
definitionId should be a UUID, you can generate one here: https://www.uuidgenerator.net/version4 |
…bac/airbyte into fea/new-captain-data-connector
@sajarin I did the suggested changes I struggle with the gradle setup :/ You can create an account easily here -> https://app.captaindata.co/signup Also, we are running this connector in production internally as a custom connector (and some of our clients too).
As soon as the connector is live, we'll do the migration with some of our clients and will monitor everything. |
@sajarin let me know if that's okay :) |
@sajarin any news? Captain Data would love to implement Airbyte Cloud and this connector for their customer as soon as possible :) |
@sajarin @marcosmarxm sorry for pinging you again Captain Data would like to suggest their customers to use Airbyte Cloud with this beta connector. Do you have an ETA for this review? |
Sorry the delay and missing reply @elliottrabac. I'll return to your contribution in this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @elliottrabac the implementation looks correct. I'm going to release the connector during the week, right now our CI is broken.
Thanks a lot! |
/approve-and-merge reason="The implementation looks good and correct, right now Airbyte doesn't have test credentials to run integration tests (it costs more 200 euros/month)." |
@marcosmarxm is the connector available on Airbyte Cloud? |
What
Describe what the change is solving
It helps to add screenshots if it affects the frontend.
Implement a new Source for Captain Data.
How
Describe the solution
Developed using (Configuration Based Source) low-code CDK.
Recommended reading order
manifest.yaml
schemas/*
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
None. New Source only.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.0.1
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes