Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Captain Data [Configuration based CDK] #25230

Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
2d4e596
initiate connector
elliottrabac Apr 15, 2023
96d0b2f
add doc
elliottrabac Apr 15, 2023
9898068
fix schema
elliottrabac Apr 15, 2023
a03337a
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Apr 18, 2023
2b3307e
add docs
elliottrabac Apr 18, 2023
082a2ed
fix comments
elliottrabac Apr 20, 2023
7158e92
add logo
elliottrabac Apr 20, 2023
df9343b
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Apr 20, 2023
46bf5ce
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Apr 21, 2023
ddbc2a1
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Apr 22, 2023
e24e5af
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac May 3, 2023
0004d1f
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac May 11, 2023
eb3cb3c
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac May 19, 2023
d8218ef
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac May 29, 2023
87376d6
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jun 9, 2023
9a63b8c
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jun 12, 2023
b81e9ac
add finished job filter
elliottrabac Jun 12, 2023
814425d
suggested changes
elliottrabac Jun 12, 2023
5555578
add metadata.yml
elliottrabac Jun 12, 2023
9846a20
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jun 12, 2023
3d936e9
Merge branch 'master' into fea/new-captain-data-connector
sajarin Jun 12, 2023
7936e84
add definition id
elliottrabac Jun 13, 2023
7001f9d
Merge branch 'fea/new-captain-data-connector' of github.com:elliottra…
elliottrabac Jun 13, 2023
12e9d94
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jun 13, 2023
3320ffc
update schemas
elliottrabac Jun 13, 2023
024d47c
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jun 13, 2023
a74791c
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jun 16, 2023
d88693b
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jun 29, 2023
0adbfb8
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jul 2, 2023
c7a0aa7
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jul 12, 2023
11b5c78
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jul 20, 2023
6bdd386
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jul 21, 2023
577e207
Merge branch 'master' into fea/new-captain-data-connector
elliottrabac Jul 24, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1015,6 +1015,47 @@
}
} ]
}
}, {
"sourceDefinitionId": "",
"name": "Captain Data",
"dockerRepository": "airbyte/source-captain-data",
"dockerImageTag": "0.1.0",
"documentationUrl": "https://docs.airbyte.com/integrations/sources/captain-data",
"icon": "captain-data.svg",
"sourceType": "api",
"spec": {
"documentationUrl": "https://docs.airbyte.com/integrations/sources/captain-data",
"connectionSpecification": {
"$schema": "https://json-schema.org/draft-07/schema#",
"title": "Captain Data Source Spec",
"type": "object",
"additionalProperties": true,
"properties": {
"api_key": {
"title": "API Key",
"type": "string",
"description": "Your Captain Data project API key.",
"airbyte_secret": true
},
"api_token": {
"title": "Project UID",
"type": "string",
"description": "Your Captain Data project uuid.",
"airbyte_secret": true
}
}
},
"supportsNormalization": false,
"supportsDBT": false,
"supported_destination_sync_modes": [ ]
},
"tombstone": false,
"public": true,
"custom": false,
"releaseStage": "alpha",
"allowedHosts": {
"hosts": [ "api.captaindata.co" ]
}
}, {
"destinationDefinitionId": "707456df-6f4f-4ced-b5c6-03f73bcad1c5",
"name": "Cassandra",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,14 @@
icon: callrail.svg
sourceType: api
releaseStage: alpha
- name: Captain Data
sourceDefinitionId: <To-be-given>
dockerRepository: airbyte/source-captain-data
dockerImageTag: 0.1.0
documentationUrl: https://docs.airbyte.com/integrations/sources/captain-data
icon: captain-data.svg
sourceType: api
releaseStage: alpha
- name: Cart.com
sourceDefinitionId: bb1a6d31-6879-4819-a2bd-3eed299ea8e2
dockerRepository: airbyte/source-cart
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2218,6 +2218,30 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-captain-data:0.1.0"
spec:
documentationUrl: https://docs.captaindata.co/#1da39f5f-a26f-4a53-9e84-3e4b28077eae
connectionSpecification:
$schema: "http://json-schema.org/draft-07/schema#"
title: Captain Data Spec
type: object
required:
- api_key
- project_uid
additionalProperties: true
properties:
api_key:
title: API Key
type: string
description: Your Captain Data project API key.
airbyte_secret: true
project_uid:
title: Project UID
type: string
description: Your Captain Data project uuid.
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-cart:0.2.1"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/cart"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
*
!Dockerfile
!main.py
!source_captain_data
!setup.py
!secrets
38 changes: 38 additions & 0 deletions airbyte-integrations/connectors/source-captain-data/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
FROM python:3.9.11-alpine3.15 as base

# build and load all requirements
FROM base as builder
WORKDIR /airbyte/integration_code

# upgrade pip to the latest version
RUN apk --no-cache upgrade \
&& pip install --upgrade pip \
&& apk --no-cache add tzdata build-base


COPY setup.py ./
# install necessary packages to a temporary folder
RUN pip install --prefix=/install .

# build a clean environment
FROM base
WORKDIR /airbyte/integration_code

# copy all loaded and built libraries to a pure basic image
COPY --from=builder /install /usr/local
# add default timezone settings
COPY --from=builder /usr/share/zoneinfo/Etc/UTC /etc/localtime
RUN echo "Etc/UTC" > /etc/timezone

# bash is installed for more convenient debugging.
RUN apk --no-cache add bash

# copy payload code only
COPY main.py ./
COPY source_captain_data ./source_captain_data

ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.name=airbyte/source-captain-data
82 changes: 82 additions & 0 deletions airbyte-integrations/connectors/source-captain-data/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
# Captain Data Source

This is the repository for the Captain Data configuration based source connector.
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.com/integrations/sources/captain-data).

## Local development

#### Building via Gradle
You can also build the connector in Gradle. This is typically used in CI and not needed for your development workflow.

To build using Gradle, from the Airbyte repository root, run:
```
./gradlew :airbyte-integrations:connectors:source-captain-data:build
```

#### Create credentials
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.com/integrations/sources/captain-data)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_captain_data/spec.yaml` file.
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
See `integration_tests/sample_config.json` for a sample config file.

**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source captain-data test creds`
and place them into `secrets/config.json`.

### Locally running the connector docker image

#### Build
First, make sure you build the latest Docker image:
```
docker build . -t airbyte/source-captain-data:dev
```

You can also build the connector image via Gradle:
```
./gradlew :airbyte-integrations:connectors:source-captain-data:airbyteDocker
```
When building via Gradle, the docker image name and tag, respectively, are the values of the `io.airbyte.name` and `io.airbyte.version` `LABEL`s in
the Dockerfile.

#### Run
Then run any of the connector commands as follows:
```
docker run --rm airbyte/source-captain-data:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-captain-data:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-captain-data:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-captain-data:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
```
## Testing

#### Acceptance Tests
Customize `acceptance-test-config.yml` file to configure tests. See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) for more information.
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.

To run your integration tests with Docker, run:
```
./acceptance-test-docker.sh
```

### Using gradle to run tests
All commands should be run from airbyte project root.
To run unit tests:
```
./gradlew :airbyte-integrations:connectors:source-captain-data:unitTest
```
To run acceptance and custom integration tests:
```
./gradlew :airbyte-integrations:connectors:source-captain-data:integrationTest
```

## Dependency Management
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
We split dependencies between two groups, dependencies that are:
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
* required for the testing need to go to `TEST_REQUIREMENTS` list

### Publishing a new version of the connector
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
1. Make sure your changes are passing unit and integration tests.
1. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use [SemVer](https://semver.org/)).
1. Create a Pull Request.
1. Pat yourself on the back for being an awesome contributor.
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference)
# for more information about how to configure these tests
connector_image: airbyte/source-captain-data:dev
acceptance_tests:
spec:
tests:
- spec_path: "source_captain_data/spec.yaml"
connection:
tests:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
tests:
- config_path: "secrets/config.json"
basic_read:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: []
incremental:
bypass_reason: "This connector does not implement incremental sync"
full_refresh:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env sh

source "$(git rev-parse --show-toplevel)/airbyte-integrations/bases/connector-acceptance-test/acceptance-test-docker.sh"
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
plugins {
id 'airbyte-python'
id 'airbyte-docker'
id 'airbyte-connector-acceptance-test'
}

airbytePython {
moduleDirectory 'source_captain_data'
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#


import pytest

pytest_plugins = ("connector_acceptance_test.plugin",)


@pytest.fixture(scope="session", autouse=True)
def connector_setup():
"""This fixture is a placeholder for external resources that acceptance test might require."""
yield
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"streams": [
{
"stream": {
"name": "workspace",
"json_schema": {},
"supported_sync_modes": ["full_refresh"]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "workflows",
"json_schema": {},
"supported_sync_modes": ["full_refresh"]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "jobs",
"json_schema": {},
"supported_sync_modes": ["full_refresh"]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"api_key": "bad-api-key",
"project_uid": "bad-project-uid"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"api_key": "api-key",
"project_uid": "project-uid"
}
13 changes: 13 additions & 0 deletions airbyte-integrations/connectors/source-captain-data/main.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#


import sys

from airbyte_cdk.entrypoint import launch
from source_captain_data import SourceCaptainData

if __name__ == "__main__":
source = SourceCaptainData()
launch(source, sys.argv[1:])
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-e ../../bases/connector-acceptance-test
-e .
29 changes: 29 additions & 0 deletions airbyte-integrations/connectors/source-captain-data/setup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#


from setuptools import find_packages, setup

MAIN_REQUIREMENTS = [
"airbyte-cdk~=0.1",
]

TEST_REQUIREMENTS = [
"pytest~=6.2",
"pytest-mock~=3.6.1",
"connector-acceptance-test",
]

setup(
name="source_captain_data",
description="Source implementation for Captain Data.",
author="Elliot Trabac",
author_email="elliot.trabac1@gmail.com",
packages=find_packages(),
install_requires=MAIN_REQUIREMENTS,
package_data={"": ["*.json", "*.yaml", "schemas/*.json", "schemas/shared/*.json"]},
extras_require={
"tests": TEST_REQUIREMENTS,
},
)
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#


from .source import SourceCaptainData

__all__ = ["SourceCaptainData"]
Loading