Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors-ci: write pytest logs to host #27042

Merged

Conversation

alafanechere
Copy link
Contributor

What

Closes #26957
We want to write pytest logs to a file as the airbyte-ci logs on standard output can be hard to read.

How

  • Capture pytest logs from Pytest with_exec stdout.
  • Write these logs to file in the connector directory, under a gitignore airbyte_ci_logs directory, the name of the file is taken from the pytest step (unit, integration, acceptance tests).

Comment on lines +6 to +10
import logging

logging.getLogger("requests").setLevel(logging.WARNING)
logging.getLogger("urllib3").setLevel(logging.WARNING)
logging.getLogger("httpx").setLevel(logging.WARNING)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a bonus to remove noise from airbyte-ci logs.

@alafanechere alafanechere requested review from bnchrch and a team June 5, 2023 21:09
@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="minor change to a dagger pipeline outside of the critical path"

@octavia-approvington
Copy link
Contributor

It's time
fine lets go

@octavia-approvington octavia-approvington merged commit 43098de into master Jun 6, 2023
@octavia-approvington octavia-approvington deleted the augustin/connectors-ci/write-pytest-logs-to-host branch June 6, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connectors-ci: acceptance test logs should be stored in a file for debugging
2 participants