-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python CDK: Relax pydantic version requirement #28854
Conversation
This PR still needs to get its protocol version bumped to 0.3.7 once it's released: https://github.com/airbytehq/airbyte/pull/28854/files#diff-4447bde589c0143e4d0c6475e78f9e945e464223a6ea052c5a7f5ee973461ba1L53 |
Had to do some slight changes to handle the CDK and pydantic update |
/legacy-publish connector=bases/source-acceptance-test auto-bump-version=false
|
/legacy-publish connector=bases/source-acceptance-test
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/legacy-publish connector=bases/connector-acceptance-test
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* relax pydantic dep * Automated Commit - Format and Process Resources Changes * update protocol models * format change --------- Co-authored-by: flash1293 <flash1293@users.noreply.github.com>
This PR relaxes the version requirement of pydantic for the CDK to make it easier to use libraries that don't work with 1.9.2
It's an updated version of #16172
As spec schemas are generated slightly differently, the CATs need to be adjusted. It's not allowed to specify
default
orenum
on the common const property as long as they only repeat theconst
value. This works fine in the UI as it only checks theconst
property: https://github.com/airbytehq/airbyte-cloud/blob/18988f9e34cb245edcdf6c1f83d78e9b64b3d71d/oss/airbyte-webapp/src/core/form/schemaToFormBlock.ts#L75and doesn't actually render any fields that have
const
set: https://github.com/airbytehq/airbyte-cloud/blob/bbb24e2f7d9525285e7a9ac73cf92b22e52ac480/oss/airbyte-webapp/src/views/Connector/ConnectorForm/components/Sections/FormSection.tsx#L33