-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source Retently: Migrate Python CDK to Low-code CDK #29040
✨Source Retently: Migrate Python CDK to Low-code CDK #29040
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Thanks for the contribution! Can you resolve the merge conflict @avirajsingh7? |
@sajarin sorry of that, resolved now |
airbyte-integrations/connectors/source-retently/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-retently/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, some minor comments after running tests locally
Signed-off-by: Aviraj Gour <100823015+avirajsingh7@users.noreply.github.com>
Signed-off-by: Aviraj Gour <100823015+avirajsingh7@users.noreply.github.com>
@sajarin can you check now? |
Thanks for the PR @avirajsingh7! This has been merged and tested in #29164. The reason why I wasn't able to merge this PR was because I needed to push some changes and run them against our CI but couldn't push to your branch since I didn't have branch permissions. Nevertheless, I forked your changes and tested in the PR aforementioned. I'm closing this PR but this should still count for the hackathon of course. fyi @RealChrisSean |
thanks @sajarin |
What
Migrating Source retently to Low-Code CDK
Closes #28118
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
Test
Acceptance Test
🚨 User Impact 🚨
No breaking changes, migration to low-code
Migrate Connector : Source retently