-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Non-Forked] ✨Source Retently: Migrate Python CDK to Low-code CDK #29164
Conversation
Signed-off-by: Aviraj Gour <100823015+avirajsingh7@users.noreply.github.com>
Signed-off-by: Aviraj Gour <100823015+avirajsingh7@users.noreply.github.com>
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-retently test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-retently/metadata.yaml | ❌ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ❌ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-retently docker image for platform linux/x86_64 | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-retently test
4d0203b
to
5a18bdc
Compare
source-retently test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-retently/metadata.yaml | ❌ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-retently docker image for platform linux/x86_64 | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-retently test
source-retently test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-retently/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-retently docker image for platform linux/x86_64 | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-retently test
source-retently test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-retently/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-retently docker image for platform linux/x86_64 | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-retently test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aamzing job Saj
source-retently test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-retently/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-retently docker image for platform linux/x86_64 | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-retently test
What
Run ci checks for #29040
Migrating Source retently to Low-Code CDK
Closes #28118
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
Test
Acceptance Test
🚨 User Impact 🚨
No breaking changes, migration to low-code
Migrate Connector : Source retently