Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Non-Forked] ✨Source Retently: Migrate Python CDK to Low-code CDK #29164

Merged
merged 17 commits into from
Aug 8, 2023

Conversation

sajarin
Copy link
Contributor

@sajarin sajarin commented Aug 7, 2023

What

Run ci checks for #29040
Migrating Source retently to Low-Code CDK
Closes #28118

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. manifest.yaml
  2. schemas/*

Test

Acceptance Test Screenshot 2023-08-03 at 6 52 13 PM

🚨 User Impact 🚨

No breaking changes, migration to low-code

Migrate Connector : Source retently
  • Community Member? Grant Edit Access to Maintainers instructions
  • Secrets in the Connector's Spec
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors::integrationTest.
  • Code Reviews Completed
    • Documentation Updated
    • Connector's README.md
    • Connector's bootstrap.md
    • docs/integrations//.md (including changelog. See changelog example)
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR Name follows PR Naming Conventions

avirajsingh7 and others added 10 commits August 3, 2023 17:55
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/retently labels Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-retently test report (commit 4d0203bd9f) - ❌

⏲️ Total pipeline duration: 03mn06s

Step Result
Validate airbyte-integrations/connectors/source-retently/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-retently docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-retently test

@octavia-squidington-iii
Copy link
Collaborator

source-retently test report (commit 5a18bdc4f9) - ❌

⏲️ Total pipeline duration: 02mn06s

Step Result
Validate airbyte-integrations/connectors/source-retently/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-retently docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-retently test

@octavia-squidington-iii
Copy link
Collaborator

source-retently test report (commit bdf75c88ec) - ✅

⏲️ Total pipeline duration: 03mn46s

Step Result
Validate airbyte-integrations/connectors/source-retently/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-retently docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-retently test

@octavia-squidington-iii
Copy link
Collaborator

source-retently test report (commit e9b2b05a8a) - ✅

⏲️ Total pipeline duration: 02mn18s

Step Result
Validate airbyte-integrations/connectors/source-retently/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-retently docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-retently test

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aamzing job Saj

@octavia-squidington-iii
Copy link
Collaborator

source-retently test report (commit e08a749f09) - ✅

⏲️ Total pipeline duration: 02mn29s

Step Result
Validate airbyte-integrations/connectors/source-retently/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-retently docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-retently test

@sajarin sajarin merged commit ba0bba8 into master Aug 8, 2023
@sajarin sajarin deleted the saj/retently-low branch August 8, 2023 16:46
@sajarin sajarin changed the title Run ci checks for ✨Source Retently: Migrate Python CDK to Low-code CDK [Non-Forked] ✨Source Retently: Migrate Python CDK to Low-code CDK Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Retently
4 participants