Vector DB CDK: Delete cdc records #32496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 14, 2023 12:35
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
aaronsteers
approved these changes
Nov 15, 2023
| if current_stream.primary_key and current_stream.destination_sync_mode == DestinationSyncMode.append_dedup: | ||
| metadata[METADATA_RECORD_ID_FIELD] = f"{stream_identifier}_{self._extract_primary_key(record, current_stream)}" | ||
| return metadata | ||
| if not current_stream.primary_key or not current_stream.destination_sync_mode == DestinationSyncMode.append_dedup: |
There was a problem hiding this comment.
Nit... Generally != or "is not" would be preferable for the "not equals" comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29827
This PR looks for the
_ab_cdc_deleted_atfield in records which signifies that this record got deleted in the source and does not produce any chunks out of it but deletes it in the destination