Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector DB CDK: Delete cdc records #32496

Merged
merged 5 commits into from
Nov 16, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix type error
Joe Reuter committed Nov 14, 2023

Verified

This commit was signed with the committer’s verified signature.
joshcooper Josh Cooper
commit 0fafe0c40e03a61242045766b0fad1d43960a2b8
Original file line number Diff line number Diff line change
@@ -162,8 +162,8 @@ def _extract_primary_key(self, record: AirbyteRecordMessage) -> Optional[str]:
primary_key.append(str(dpath.util.get(record.data, key)))
except KeyError:
primary_key.append("__not_found__")
primary_key = "_".join(primary_key)
return f"{stream_identifier}_{primary_key}"
stringified_primary_key = "_".join(primary_key)
return f"{stream_identifier}_{stringified_primary_key}"

def _split_document(self, doc: Document) -> List[Document]:
chunks: List[Document] = self.splitter.split_documents([doc])