Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addmjooq to the explicit dependencies of source-mssql #35126

Conversation

stephane-airbyte
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 16, 2024 0:49am

Copy link
Contributor Author

stephane-airbyte commented Feb 10, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@stephane-airbyte stephane-airbyte force-pushed the stephane/02-10-addmjooq_to_the_explicit_dependencies_of_source-mssql branch 2 times, most recently from 213afd7 to 463eec1 Compare February 10, 2024 17:17
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from 3f28bce to 479c231 Compare February 13, 2024 19:31
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-10-addmjooq_to_the_explicit_dependencies_of_source-mssql branch from 463eec1 to 0e36cf2 Compare February 13, 2024 19:31
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from 479c231 to 5c84710 Compare February 13, 2024 19:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-10-addmjooq_to_the_explicit_dependencies_of_source-mssql branch from 0e36cf2 to ce249a8 Compare February 13, 2024 19:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from 5c84710 to 962841b Compare February 16, 2024 00:48
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-10-addmjooq_to_the_explicit_dependencies_of_source-mssql branch from ce249a8 to 9d5fab0 Compare February 16, 2024 00:48
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch 7 times, most recently from acb9bdf to 0050395 Compare February 16, 2024 20:29
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from 0050395 to d7900a6 Compare February 18, 2024 01:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from d7900a6 to 7e4c49a Compare February 19, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants