airbyte-ci: rename StepResult.output artifact to StepResult.output #35490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
alafanechere
force-pushed
the
augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports
branch
from
aec7b97 to
71392b3
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/02-21-airbyte-ci_rename_StepResult.output_artifact_to_StepResult.output
branch
from
fd3c03a to
f3b0a1a
Compare
alafanechere
force-pushed
the
augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports
branch
from
71392b3 to
38567f7
Compare
stephane-airbyte
force-pushed
the
augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports
branch
2 times, most recently
from
80b7935 to
efc35d8
Compare
stephane-airbyte
force-pushed
the
augustin/02-21-airbyte-ci_rename_StepResult.output_artifact_to_StepResult.output
branch
from
f3b0a1a to
e8d0597
Compare
This was referenced Feb 21, 2024
This was referenced Feb 21, 2024
Closed
stephane-airbyte
force-pushed
the
augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports
branch
from
efc35d8 to
e891176
Compare
stephane-airbyte
force-pushed
the
augustin/02-21-airbyte-ci_rename_StepResult.output_artifact_to_StepResult.output
branch
from
e8d0597 to
64b93e4
Compare
stephane-airbyte
force-pushed
the
augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports
branch
from
e891176 to
60f1613
Compare
stephane-airbyte
force-pushed
the
augustin/02-21-airbyte-ci_rename_StepResult.output_artifact_to_StepResult.output
branch
from
64b93e4 to
a83baa1
Compare
stephane-airbyte
force-pushed
the
augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports
branch
from
60f1613 to
3d521a4
Compare
stephane-airbyte
force-pushed
the
augustin/02-21-airbyte-ci_rename_StepResult.output_artifact_to_StepResult.output
branch
from
a83baa1 to
3c6b12d
Compare
postamar
approved these changes
Feb 22, 2024
| @@ -74,7 +74,7 @@ class Result: | |||
| stdout: Optional[str] = None | |||
| report: Optional[str] = None | |||
There was a problem hiding this comment.
Can we get rid of this field, which I introduced?
stephane-airbyte
force-pushed
the
augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports
branch
from
3d521a4 to
823b5c4
Compare
stephane-airbyte
force-pushed
the
augustin/02-21-airbyte-ci_rename_StepResult.output_artifact_to_StepResult.output
branch
from
3c6b12d to
2a47e7d
Compare
Base automatically changed from
augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports
to
stephane/02-13-make_airbyte-ci_pass_a_parameter_to_the_java_connectors_to_the_location_of_the_logs
February 22, 2024 15:16
stephane-airbyte
merged commit 2a47e7d
into
stephane/02-13-make_airbyte-ci_pass_a_parameter_to_the_java_connectors_to_the_location_of_the_logs
22 checks passed
stephane-airbyte
deleted the
augustin/02-21-airbyte-ci_rename_StepResult.output_artifact_to_StepResult.output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35479 introduced the StepResult.artifacts attribute. I think we should rename
StepResult.output_artifacttoStepResult.output.outputare used to pass objects between steps. They are close the concept of artifacts but an additional refactor should be considered to merge both concepts.