Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Facebook Pages: Upgrade Facebook API to v19.0 #35433

Closed
wants to merge 2 commits into from

Conversation

airt
Copy link
Contributor

@airt airt commented Feb 20, 2024

What

How

  • Upgrade Facebook API to v19.0

Recommended reading order

  1. airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/manifest.yaml

User Impact

  1. Invalid field removed: messenger_ads_default_page_welcome_message

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 7:35am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/facebook-pages labels Feb 20, 2024
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@marcosmarxm
Copy link
Member

Thanks for the contribution @airt I requested to the connector team to review it.

@marcosmarxm
Copy link
Member

Solved by #35746 sorry the lack of update here @airt

@marcosmarxm marcosmarxm closed this Mar 7, 2024
@airt
Copy link
Contributor Author

airt commented Mar 8, 2024

Solved by #35746 sorry the lack of update here @airt

@marcosmarxm Seems that #35746 is for Marketing and this one is for Pages, they are not the same source 😂

@marcosmarxm marcosmarxm reopened this Mar 8, 2024
@marcosmarxm
Copy link
Member

lol!!!! my baddd @airt

@midavadim
Copy link
Contributor

I close this PR since API version was updated in another PR:
#36015

@midavadim midavadim closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Facebook Pages: migrate API to v19.0
4 participants