Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨🚨 Source Facebook Marketing: update API to v19.0 #35746

Merged
merged 18 commits into from
Mar 6, 2024
Merged

🚨🚨 Source Facebook Marketing: update API to v19.0 #35746

merged 18 commits into from
Mar 6, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Mar 1, 2024 •
edited
Loading

What

Resolve https://github.com/airbytehq/oncall/issues/4439, #35334

How

update facebook api to v19.0

Recommended reading order

  1. airbyte-integrations/connectors/source-facebook-marketing/pyproject.toml

🚨 User Impact 🚨

schema changes in Ads-Insights-* reports

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds then checking in your changes
  • Documentation which references the generator is updated as needed

artem1205 added 2 commits March 1, 2024 13:06
@artem1205
Source Facebook Marketing: format
afa652d 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
Source Facebook Marketing: update to v19.0 [no ci]
a4f7092 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@vercel Vercel
Copy link

vercel bot commented Mar 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 9:06pm

@artem1205 artem1205 changed the title Artem1205/source facebook marketing oc 4439 Source Facebook Marketing: update API to v19.0 Mar 1, 2024
@artem1205 artem1205 self-assigned this Mar 1, 2024
@artem1205
Source Facebook Marketing: update docs [no ci]
813e43e 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 1, 2024
@artem1205 artem1205 marked this pull request as ready for review March 1, 2024 12:52
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 1, 2024 13:04
artem1205 added 7 commits March 1, 2024 15:03
@artem1205
Source Facebook Marketing: update spec
4925afd 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
Source Facebook Marketing: update schema
6eae5c7 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
Source Facebook Marketing: update schema
1e26dde 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
Source Facebook Marketing: update integration tests
7d2e390 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
Source Facebook Marketing: update metadata breaking changes
b7223fe 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
Source Facebook Marketing: add docs
ee7832b 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
Source Facebook Marketing: update version
ecff5d6 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 1, 2024 21:30
@artem1205
Source Facebook Marketing: update version
d82c104 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 linked an issue Mar 4, 2024 that may be closed by this pull request
[source-facebook-marketing] fields are not valid for fields param after V19.0 #35334
Closed
1 task
@artem1205 artem1205 added the breaking-change Don't merge me unless you are ready. label Mar 4, 2024
@artem1205 artem1205 changed the title Source Facebook Marketing: update API to v19.0 🚨🚨 Source Facebook Marketing: update API to v19.0 Mar 4, 2024
katmarkham
katmarkham requested changes Mar 4, 2024
View reviewed changes
airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml Outdated
releases:
breakingChanges:
2.0.0:
message: "All Ads-Insights-* streams now have updated schemas."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the user action needed here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 4, 2024 15:54
artem1205 added 2 commits March 4, 2024 18:25
@artem1205
Merge remote-tracking branch 'origin/master' into artem1205/source-fa…
1c17783 
…cebook-marketing-OC-4439
@artem1205
Source SalesForce: update docs [skip ci]
1a8f7b2 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 requested a review from katmarkham March 4, 2024 17:44
@aaronsteers aaronsteers mentioned this pull request Mar 5, 2024
Closed
@artem1205 artem1205 merged commit e10826c into master Mar 6, 2024
29 checks passed
@artem1205 artem1205 deleted the artem1205/source-facebook-marketing-OC-4439 branch March 6, 2024 09:44
xiaohansong pushed a commit that referenced this pull request Mar 7, 2024
@artem1205 @xiaohansong
🚨🚨 Source Facebook Marketing: update API to v19.0 (#35746)
28382d7 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@marcosmarxm marcosmarxm mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katmarkham katmarkham katmarkham approved these changes

@bazarnov bazarnov bazarnov approved these changes

Assignees

@artem1205 artem1205

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation breaking-change Don't merge me unless you are ready. connectors/source/facebook-marketing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[source-facebook-marketing] fields are not valid for fields param after V19.0
4 participants
@artem1205 @bazarnov @katmarkham @octavia-squidington-iii