🚨🚨🐛Source Amazon Seller Partner: update schema for `GET_FBA_STORAGE_FEE_CHARGES_DATA` stream #35439

askarpets · 2024-02-20T11:52:08Z

What

Update the schema for the GET_FBA_STORAGE_FEE_CHARGES_DATA stream according to the request in certification checklist and Amazon docs

🚨 User Impact 🚨

This is a breaking change as field names in the GET_FBA_STORAGE_FEE_CHARGES_DATA stream's schema have been renamed

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

…HARGES_DATA stream

vercel · 2024-02-20T11:52:15Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 29, 2024 8:32am

github-actions · 2024-02-20T11:52:36Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

tolik0 · 2024-02-20T14:43:26Z

Should this be a breaking change, as this PR can affect OSS users?

lazebnyi · 2024-02-20T17:51:18Z

...on-seller-partner/source_amazon_seller_partner/schemas/GET_FBA_STORAGE_FEE_CHARGES_DATA.json

@@ -85,16 +85,16 @@
    "qualifies_for_inventory_discount": {
      "type": ["null", "string"]
    },
-    "storage-utilization-ratio": {
+    "storage_utilization_ratio": {


Is it braking change?

I would say yes if there were active users of the stream on cloud (based on this page). Since there are no customers, I decided not to mark this PR as a breaking change, however, based on @tolik0's comment above, this might affect OSS users. I don't know if the same logic of connector upgrade applies to them, so could you please advice if I should consider this as a breaking change?

Yes, let's mark this as braking changes.

Updated, please take a look

katmarkham · 2024-02-23T13:53:52Z

airbyte-integrations/connectors/source-amazon-seller-partner/metadata.yaml

          Users will need to refresh the source schemas and reset these streams after upgrading.
        upgradeDeadline: "2024-01-12"
+      4.0.0:
+        message:
+          Stream `GET_FBA_STORAGE_FEE_CHARGES_DATA` now has updated schema, which matches Amazon Seller Partner docs.


Stream GET_FBA_STORAGE_FEE_CHARGES_DATA schema has been updated to match Amazon Seller Partner.

katmarkham · 2024-02-23T13:54:42Z

airbyte-integrations/connectors/source-amazon-seller-partner/metadata.yaml

+      4.0.0:
+        message:
+          Stream `GET_FBA_STORAGE_FEE_CHARGES_DATA` now has updated schema, which matches Amazon Seller Partner docs.
+          Users will need to refresh the source schemas and reset these streams after upgrading.


Users will need to refresh the source schema and reset this stream after upgrading.

katmarkham · 2024-02-23T13:54:58Z

airbyte-integrations/connectors/source-amazon-seller-partner/metadata.yaml

+        message:
+          Stream `GET_FBA_STORAGE_FEE_CHARGES_DATA` now has updated schema, which matches Amazon Seller Partner docs.
+          Users will need to refresh the source schemas and reset these streams after upgrading.
+        upgradeDeadline: "2024-03-11"


Does this autolink to the migration guide?

No. Do you have an example of how this should look like?

katmarkham · 2024-02-23T13:57:58Z

docs/integrations/sources/amazon-seller-partner-migrations.md

+
+Stream `GET_FBA_STORAGE_FEE_CHARGES_DATA` now has updated schema, which matches Amazon Seller Partner [docs](https://developer-docs.amazon.com/sp-api/docs/fba-inventory-reports-attributes#get_fba_storage_fee_charges_data).
+
+Users will need to refresh the source schemas and reset these streams after upgrading.


Users will need to refresh the source schema and reset this stream after upgrading.

Source Amazon Seller Partner: update schema for GET_FBA_STORAGE_FEE_C…

f251a77

…HARGES_DATA stream

askarpets self-assigned this Feb 20, 2024

octavia-squidington-iii added area/connectors Connector related issues connectors/source/amazon-seller-partner labels Feb 20, 2024

askarpets changed the title ~~Source Amazon Seller Partner: update schema for GET_FBA_STORAGE_FEE_CHARGES_DATA stream~~ 🐛Source Amazon Seller Partner: update schema for GET_FBA_STORAGE_FEE_CHARGES_DATA stream Feb 20, 2024

octavia-squidington-iv requested a review from a team February 20, 2024 11:53

Update docs

146a688

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 20, 2024

vercel bot deployed to Preview February 20, 2024 11:59 View deployment

askarpets requested review from artem1205 and lazebnyi February 20, 2024 12:34

roman-yermilov-gl approved these changes Feb 20, 2024

View reviewed changes

Migrate to Poetry

8285ed6

lazebnyi reviewed Feb 20, 2024

View reviewed changes

bazarnov approved these changes Feb 21, 2024

View reviewed changes

askarpets added 2 commits February 21, 2024 14:45

Merge branch 'master' into source-amazon-seller-partner-fix-schema

20b8341

Update migration guide

245aea2

askarpets changed the title ~~🐛Source Amazon Seller Partner: update schema for GET_FBA_STORAGE_FEE_CHARGES_DATA stream~~ 🚨🚨🐛Source Amazon Seller Partner: update schema for GET_FBA_STORAGE_FEE_CHARGES_DATA stream Feb 21, 2024

octavia-squidington-iv requested a review from a team February 21, 2024 12:47

vercel bot deployed to Preview February 21, 2024 12:50 View deployment

Update version in pyproject.toml

0bd7b7f

katmarkham requested changes Feb 23, 2024

View reviewed changes

octavia-squidington-iv requested a review from a team February 23, 2024 13:59

askarpets added 2 commits February 23, 2024 16:16

Merge branch 'master' into source-amazon-seller-partner-fix-schema

b42bd0b

Update docs

41186da

vercel bot deployed to Preview February 23, 2024 14:20 View deployment

askarpets requested a review from katmarkham February 23, 2024 14:33

katmarkham approved these changes Feb 27, 2024

View reviewed changes

askarpets added 3 commits February 28, 2024 16:31

Merge branch 'master' into source-amazon-seller-partner-fix-schema

cbf1091

Update readme

9c619ed

Merge branch 'master' into source-amazon-seller-partner-fix-schema

3b10450

vercel bot deployed to Preview February 28, 2024 19:08 View deployment

Merge branch 'master' into source-amazon-seller-partner-fix-schema

18ab16b

vercel bot deployed to Preview February 29, 2024 08:32 View deployment

askarpets merged commit edcc2fa into master Feb 29, 2024
29 checks passed

askarpets deleted the source-amazon-seller-partner-fix-schema branch February 29, 2024 09:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚨🚨🐛Source Amazon Seller Partner: update schema for `GET_FBA_STORAGE_FEE_CHARGES_DATA` stream #35439

🚨🚨🐛Source Amazon Seller Partner: update schema for `GET_FBA_STORAGE_FEE_CHARGES_DATA` stream #35439

askarpets commented Feb 20, 2024 •

edited

Loading

vercel bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited by askarpets

Loading

tolik0 commented Feb 20, 2024

lazebnyi Feb 20, 2024

askarpets Feb 21, 2024

lazebnyi Feb 21, 2024

askarpets Feb 21, 2024

katmarkham Feb 23, 2024

askarpets Feb 23, 2024

katmarkham Feb 23, 2024

askarpets Feb 23, 2024

katmarkham Feb 23, 2024

askarpets Feb 23, 2024

katmarkham Feb 23, 2024

askarpets Feb 23, 2024


		Stream `GET_FBA_STORAGE_FEE_CHARGES_DATA` now has updated schema, which matches Amazon Seller Partner [docs](https://developer-docs.amazon.com/sp-api/docs/fba-inventory-reports-attributes#get_fba_storage_fee_charges_data).

		Users will need to refresh the source schemas and reset these streams after upgrading.

🚨🚨🐛Source Amazon Seller Partner: update schema for GET_FBA_STORAGE_FEE_CHARGES_DATA stream #35439

🚨🚨🐛Source Amazon Seller Partner: update schema for GET_FBA_STORAGE_FEE_CHARGES_DATA stream #35439

Conversation

askarpets commented Feb 20, 2024 • edited Loading

What

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

vercel bot commented Feb 20, 2024 • edited Loading

github-actions bot commented Feb 20, 2024 • edited by askarpets Loading

Before Merging a Connector Pull Request

tolik0 commented Feb 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

🚨🚨🐛Source Amazon Seller Partner: update schema for `GET_FBA_STORAGE_FEE_CHARGES_DATA` stream #35439

🚨🚨🐛Source Amazon Seller Partner: update schema for `GET_FBA_STORAGE_FEE_CHARGES_DATA` stream #35439

askarpets commented Feb 20, 2024 •

edited

Loading

vercel bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited by askarpets

Loading