Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨🚨🐛Source Amazon Seller Partner: update schema for GET_FBA_STORAGE_FEE_CHARGES_DATA stream #35439

Merged
merged 12 commits into from
Feb 29, 2024
Merged

🚨🚨🐛Source Amazon Seller Partner: update schema for GET_FBA_STORAGE_FEE_CHARGES_DATA stream #35439

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f251a77
Source Amazon Seller Partner: update schema for GET_FBA_STORAGE_FEE_C…
Feb 20, 2024
146a688
Update docs
Feb 20, 2024
8285ed6
Migrate to Poetry
Feb 20, 2024
20b8341
Merge branch 'master' into source-amazon-seller-partner-fix-schema
Feb 21, 2024
245aea2
Update migration guide
Feb 21, 2024
0bd7b7f
Update version in pyproject.toml
Feb 21, 2024
b42bd0b
Merge branch 'master' into source-amazon-seller-partner-fix-schema
Feb 23, 2024
41186da
Update docs
Feb 23, 2024
cbf1091
Merge branch 'master' into source-amazon-seller-partner-fix-schema
Feb 28, 2024
9c619ed
Update readme
Feb 28, 2024
3b10450
Merge branch 'master' into source-amazon-seller-partner-fix-schema
Feb 28, 2024
18ab16b
Merge branch 'master' into source-amazon-seller-partner-fix-schema
Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amazon-seller-partner/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: e55879a8-0ef8-4557-abcf-ab34c53ec460
dockerImageTag: 3.5.0
dockerImageTag: 3.5.1
dockerRepository: airbyte/source-amazon-seller-partner
documentationUrl: https://docs.airbyte.com/integrations/sources/amazon-seller-partner
githubIssueLabel: source-amazon-seller-partner
Expand Down
50 changes: 25 additions & 25 deletions ...seller-partner/source_amazon_seller_partner/schemas/GET_FBA_STORAGE_FEE_CHARGES_DATA.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,73 +10,73 @@
"fnsku": {
"type": ["null", "string"]
},
"product-name": {
"product_name": {
"type": ["null", "string"]
},
"fulfillment-center": {
"fulfillment_center": {
"type": ["null", "string"]
},
"country-code": {
"country_code": {
"type": ["null", "string"]
},
"longest-side": {
"longest_side": {
"type": ["null", "string"]
},
"median-side": {
"median_side": {
"type": ["null", "string"]
},
"shortest-side": {
"shortest_side": {
"type": ["null", "string"]
},
"measurement-units": {
"measurement_units": {
"type": ["null", "string"]
},
"weight": {
"type": ["null", "string"]
},
"weight-units": {
"weight_units": {
"type": ["null", "string"]
},
"item-volume": {
"item_volume": {
"type": ["null", "string"]
},
"volume-units": {
"volume_units": {
"type": ["null", "string"]
},
"product-size-tier": {
"product_size_tier": {
"type": ["null", "string"]
},
"average-quantity-on-hand": {
"average_quantity_on_hand": {
"type": ["null", "string"]
},
"average-quantity-pending-removal": {
"average_quantity_pending_removal": {
"type": ["null", "string"]
},
"estimated-total-item-volume": {
"estimated_total_item_volume": {
"type": ["null", "string"]
},
"month-of-charge": {
"month_of_charge": {
"type": ["null", "string"]
},
"storage-rate": {
"storage_rate": {
"type": ["null", "string"]
},
"estimated-monthly-storage-fee": {
"estimated_monthly_storage_fee": {
"type": ["null", "string"]
},
"currency": {
"type": ["null", "string"]
},
"average-quantity-customer-orders": {
"average_quantity_customer_orders": {
"type": ["null", "number"]
},
"base-rate": {
"base_rate": {
"type": ["null", "number"]
},
"breakdown-incentive-fee-amount": {
"breakdown_incentive_fee_amount": {
"type": ["null", "string"]
},
"dangerous-goods-storage-type": {
"dangerous_goods_storage_type": {
"type": ["null", "string"]
},
"eligible_for_inventory_discount": {
Expand All @@ -85,16 +85,16 @@
"qualifies_for_inventory_discount": {
"type": ["null", "string"]
},
"storage-utilization-ratio": {
"storage_utilization_ratio": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it braking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say yes if there were active users of the stream on cloud (based on this page). Since there are no customers, I decided not to mark this PR as a breaking change, however, based on @tolik0's comment above, this might affect OSS users. I don't know if the same logic of connector upgrade applies to them, so could you please advice if I should consider this as a breaking change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's mark this as braking changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, please take a look

"type": ["null", "number"]
},
"storage-utilization-ratio-units": {
"storage_utilization_ratio_units": {
"type": ["null", "string"]
},
"total-incentive-fee-amount": {
"total_incentive_fee_amount": {
"type": ["null", "number"]
},
"utilization-surcharge-rate": {
"utilization_surcharge_rate": {
"type": ["null", "number"]
},
"dataEndTime": {
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/amazon-seller-partner.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ Information about rate limits you may find [here](https://developer-docs.amazon.

| Version | Date | Pull Request | Subject |
|:---------|:-----------|:------------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `3.5.1` | 2024-02-20 | [\#35439](https://github.com/airbytehq/airbyte/pull/35439) | Update schema for the `GET_FBA_STORAGE_FEE_CHARGES_DATA` stream |
| `3.5.0` | 2024-02-09 | [\#35331](https://github.com/airbytehq/airbyte/pull/35331) | Fix check for Vendor accounts. Add failed report result message |
| `3.4.0` | 2024-02-15 | [\#35273](https://github.com/airbytehq/airbyte/pull/35273) | Add `VendorOrders` stream |
| `3.3.2` | 2024-02-13 | [\#33996](https://github.com/airbytehq/airbyte/pull/33996) | Add integration tests |
Expand Down
Loading