low-code: Add last_page_size and last_record to pagination context #36408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
girarda
commented
Mar 26, 2024
| decoded_response = self.decoder.decode(response) | ||
|
|
||
| # The default way that link is presented in requests.Response is a string of various links (last, next, etc). This | ||
| # is not indexable or useful for parsing the cursor, so we replace it with the link dictionary from response.links | ||
| headers = response.headers | ||
| headers: Dict[str, Any] = dict(response.headers) |
| self.config, | ||
| response=decoded_response, | ||
| headers=headers, | ||
| last_records=last_records, |
There was a problem hiding this comment.
last_records will be removed in a follow up PR
| token = self.cursor_value.eval(config=self.config, last_records=last_records, response=decoded_response, headers=headers) | ||
| token = self._cursor_value.eval( | ||
| config=self.config, | ||
| last_records=last_records, |
There was a problem hiding this comment.
last_records will be removed in a follow up PR
…m:airbytehq/airbyte into alex/replace_last_records_from_paginators
This was referenced Mar 26, 2024
brianjlai
approved these changes
Apr 2, 2024
| headers["link"] = response.links | ||
|
|
||
| if self.stop_condition: | ||
| should_stop = self.stop_condition.eval(self.config, response=decoded_response, headers=headers, last_records=last_records) | ||
| last_record = last_records[-1] if last_records else None |
There was a problem hiding this comment.
and this would presumably be removed later in favor of an incoming last_record param as per the description?
There was a problem hiding this comment.
that's right. It'll be passed as a param
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
last_page_sizeandlast_recordinterpolation variables to the cursor pagination strategy as a first step towards closing https://github.com/airbytehq/airbyte-internal-issues/issues/6554.These two variables are meant to replace
last_records, which is now removed from the documented interpolation context. The field should now be considered to be deprecated. It will be deleted in a follow up PR.last_records: update low-code connectors using last_records #36409