update low-code connectors using last_records #36409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
girarda
commented
Mar 22, 2024
| @@ -1,185 +1,5 @@ | |||
| { | |||
| "streams": [ | |||
| { | |||
There was a problem hiding this comment.
FIX:ME undo this change
girarda
commented
Mar 25, 2024
| @@ -55,7 +55,7 @@ definitions: | |||
| type: "DefaultPaginator" | |||
| pagination_strategy: | |||
| type: "CursorPagination" | |||
| cursor_value: "{{ last_records['meta', 'pagination', 'next_offset'] }}" | |||
| cursor_value: "{{ last_record['meta', 'pagination', 'next_offset'] }}" | |||
There was a problem hiding this comment.
CATs are failing on master too.
I'm also not sure how this can work on master since last_records should be an array, not an object
| @@ -53,7 +53,7 @@ definitions: | |||
| type: "DefaultPaginator" | |||
| pagination_strategy: | |||
| type: "CursorPagination" | |||
| cursor_value: "{{ last_records['href'] }}" | |||
| cursor_value: "{{ last_record['href'] }}" | |||
There was a problem hiding this comment.
confirmed CATs pass
| @@ -33,7 +33,7 @@ definitions: | |||
| type: "DefaultPaginator" | |||
| pagination_strategy: | |||
| type: "CursorPagination" | |||
| cursor_value: "{{ last_records['next'] }}" | |||
| cursor_value: "{{ last_record['next'] }}" | |||
There was a problem hiding this comment.
confirmed CATs pass
| @@ -12,7 +12,6 @@ | |||
| TEST_REQUIREMENTS = [ | |||
| "pytest~=6.2", | |||
| "pytest-mock~=3.6.1", | |||
| "connector-acceptance-test", | |||
There was a problem hiding this comment.
this library isn't needed by the connector
| @@ -28,7 +28,7 @@ definitions: | |||
| type: "DefaultPaginator" | |||
| pagination_strategy: | |||
| type: "CursorPagination" | |||
| cursor_value: "{{ last_records[-1]['scrollId'] }}" | |||
| cursor_value: "{{ last_record['scrollId'] }}" | |||
There was a problem hiding this comment.
Confirmed CATs pass
| @@ -39,7 +39,7 @@ definitions: | |||
| type: "DefaultPaginator" | |||
| pagination_strategy: | |||
| type: "CursorPagination" | |||
| cursor_value: "{{ last_records['paging', 'next'] }}" | |||
| cursor_value: "{{ last_record['paging', 'next'] }}" | |||
There was a problem hiding this comment.
Confirmed CATs pass
| @@ -24,7 +24,7 @@ definitions: | |||
| type: DefaultPaginator | |||
| pagination_strategy: | |||
| type: "CursorPagination" | |||
| cursor_value: "{{ last_records[-1]['key'] }}" | |||
| cursor_value: "{{ last_record['key'] }}" | |||
There was a problem hiding this comment.
tests don't pass on master
…m:airbytehq/airbyte into alex/replace_last_records_from_paginators
…op_using_last_records
Base automatically changed from
alex/replace_last_records_from_paginators
to
master
April 2, 2024 17:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update connectors to use
last_recordinstead oflast_records, which is being deprecated by #36408