Destination redshift: Remove encrypted staging option #39141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jun 5, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gisripa
approved these changes
Jun 5, 2024
evantahler
approved these changes
Jun 6, 2024
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
d0495a9 to
91123ed
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
d0273c2 to
3d0e7d3
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
91123ed to
769fb16
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
3d0e7d3 to
026cf75
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
769fb16 to
4c815f2
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
026cf75 to
2e369fc
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
4c815f2 to
6486614
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
2e369fc to
f7a341e
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
6486614 to
52effe1
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
f7a341e to
c8a8803
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
52effe1 to
a629806
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
c8a8803 to
f2e7dca
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
a629806 to
7b7e9d4
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
f2e7dca to
39746f3
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
7b7e9d4 to
c7bc16b
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
39746f3 to
88f703f
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
c7bc16b to
b89aa67
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
c783a09 to
6776c9c
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
ec8d683 to
de53471
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
6776c9c to
a4c065e
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
de53471 to
a62804b
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
a4c065e to
ba84a5a
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
a62804b to
77a62d5
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
ba84a5a to
07e77e8
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
77a62d5 to
12b3d84
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
07e77e8 to
5ab2266
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
12b3d84 to
a0a9aab
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
5ab2266 to
8e2fa50
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
a0a9aab to
4cb52bc
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
8e2fa50 to
326d11e
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
4cb52bc to
b7434d0
Compare
edgao
force-pushed
the
edgao/redshift_remove_encryption_option
branch
from
b7434d0 to
cd415ea
Compare
octavia-squidington-iii
added
the
area/documentation
This was referenced Jun 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discovered in https://github.com/airbytehq/oncall/issues/5422
this option has never worked. It was added in #14013, which copied the Snowflake SQL syntax from #12452. Redshift's SQL incantation is slightly different; attempting to use this option results in a syntax error.
Let's just remove the option for now (it has never worked, and nobody is currently using it). I submitted https://github.com/airbytehq/airbyte-internal-issues/issues/8164 to fix it, but... nobody is exactly clamoring for this feature, so 🤷
(I reserve the right to delete the relevant code in a later PR in this stack, but leaving it as-is for now)