-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination Databricks: Implement refreshes #40692
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5ea3ddb
to
4aa4151
Compare
1a8a7e1
to
fb8cd1f
Compare
4aa4151
to
d7589bf
Compare
fb8cd1f
to
cd225fd
Compare
d7589bf
to
ee4d4d4
Compare
cd225fd
to
e525669
Compare
ee4d4d4
to
0c533f1
Compare
e525669
to
3a1a034
Compare
0c533f1
to
100d7ad
Compare
3a1a034
to
3b19eae
Compare
100d7ad
to
8d8804d
Compare
3b19eae
to
949b034
Compare
8d8804d
to
a08885a
Compare
949b034
to
5c437fe
Compare
a08885a
to
859842c
Compare
5c437fe
to
b20cade
Compare
859842c
to
76745ef
Compare
b20cade
to
fc1c851
Compare
6dfd22e
to
fb7d6ae
Compare
fc1c851
to
7f388a3
Compare
d0f2bb7
to
c0d3d7b
Compare
c0d3d7b
to
96a5c3a
Compare
96a5c3a
to
1615fac
Compare
private fun prepareStagingTable(streamId: StreamId, destinationSyncMode: DestinationSyncMode) { | ||
val rawSchema = streamId.rawNamespace | ||
// TODO: Optimize by running SHOW SCHEMAS; rather than CREATE SCHEMA if not exists | ||
destinationHandler.execute(sqlGenerator.createSchema(rawSchema)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the create schema
call now happens via destinationhandler.createNamespaces, so remove it from here
1615fac
to
97b7de0
Compare
d43bca7
to
06bbab7
Compare
...icks/src/main/kotlin/io/airbyte/integrations/destination/databricks/DatabricksDestination.kt
Show resolved
Hide resolved
...otlin/io/airbyte/integrations/destination/databricks/operation/DatabricksStorageOperation.kt
Show resolved
Hide resolved
...otlin/io/airbyte/integrations/destination/databricks/operation/DatabricksStorageOperation.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- the overridden methods do what they seem like they should
- the statements made about databricks in comments, etc are correct
- the net new behavior makes sense with my understanding of what supporting refreshes means
- the tests look thorough and correct but I didn't have time to go over them all in detail
06bbab7
to
c9a620d
Compare
c9a620d
to
6fccc25
Compare
closes https://github.com/airbytehq/airbyte-internal-issues/issues/8534. closes https://github.com/airbytehq/airbyte-internal-issues/issues/8835. closes https://github.com/airbytehq/airbyte-internal-issues/issues/8857#issuecomment-2259169235. Structurally identical to all the other refreshes PRs (e.g. #38713).
❗ this PR also unpins the current version, i.e. we will release the connector publicly here.
As a refresher:
check
(wasn't deleting the test table). Added a test case for this.I'll do a prerelease image + set up a sync in the perf test workspace, but in the meantime, this should be ready for review.